public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH 2/2] libext2fs: remove useless code in ext2fs_super_and_bgd_loc2
Date: Wed, 16 Nov 2011 09:02:08 +0800	[thread overview]
Message-ID: <1321405328-5298-2-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1321405328-5298-1-git-send-email-xiaoqiangnk@gmail.com>

Code below is useless because has_super is either 0 or 1.

if (has_super)
	has_super = 1;

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 lib/ext2fs/closefs.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/lib/ext2fs/closefs.c b/lib/ext2fs/closefs.c
index 973c2a2..54a24f8 100644
--- a/lib/ext2fs/closefs.c
+++ b/lib/ext2fs/closefs.c
@@ -102,8 +102,6 @@ errcode_t ext2fs_super_and_bgd_loc2(ext2_filsys fs,
 		if (((group % meta_bg_size) == 0) ||
 		    ((group % meta_bg_size) == 1) ||
 		    ((group % meta_bg_size) == (meta_bg_size-1))) {
-			if (has_super)
-				has_super = 1;
 			new_desc_blk = group_block + has_super;
 			numblocks++;
 		}
-- 
1.7.5.1


  reply	other threads:[~2011-11-16  3:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16  1:02 [PATCH 1/2] dumpe2fs: dump blocks count used by super and GDT Yongqiang Yang
2011-11-16  1:02 ` Yongqiang Yang [this message]
2011-11-20  4:43 ` Ted Ts'o
2011-11-20  7:08   ` Yongqiang Yang
2011-11-20 18:28     ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321405328-5298-2-git-send-email-xiaoqiangnk@gmail.com \
    --to=xiaoqiangnk@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox