From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH 5/6] ext4: remove useless code in ext4_ext_split
Date: Thu, 17 Nov 2011 10:03:24 +0800 [thread overview]
Message-ID: <1321495405-9583-5-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1321495405-9583-1-git-send-email-xiaoqiangnk@gmail.com>
New allocated blocks have been checked after allocating,
so there is no need to recheck them.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/extents.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 720070d..d483635 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -857,11 +857,6 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode,
/* initialize new leaf */
newblock = ablocks[--a];
- if (unlikely(newblock == 0)) {
- EXT4_ERROR_INODE(inode, "newblock == 0!");
- err = -EIO;
- goto cleanup;
- }
bh = sb_getblk(inode->i_sb, newblock);
if (!bh) {
err = -EIO;
--
1.7.5.1
next prev parent reply other threads:[~2011-11-17 4:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 2:03 [PATCH 1/6] ext4: remove unnecessary var in ext4_ext_insert_extent Yongqiang Yang
2011-11-17 2:03 ` [PATCH 2/6] ext4: remove useless BUG_ON " Yongqiang Yang
2011-11-17 2:03 ` [PATCH 3/6] ext4: correct comment on extent merging " Yongqiang Yang
2011-11-17 2:03 ` [PATCH 4/6] ext4: remove code related to punching hole from ext4_ext_insert_extent Yongqiang Yang
2011-11-17 16:56 ` Andreas Dilger
2011-11-18 3:19 ` Yongqiang Yang
2011-12-01 20:55 ` Allison Henderson
2011-12-02 1:09 ` Yongqiang Yang
2011-11-17 2:03 ` Yongqiang Yang [this message]
2011-11-17 2:03 ` [PATCH 6/6] ext4: move code checking if leaf is full to the beginning of ext4_ext_split Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321495405-9583-5-git-send-email-xiaoqiangnk@gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).