* [PATCH 1/2] [PATCH] ext4: fix ext4_debug format
@ 2011-11-17 7:19 Zheng Liu
2011-11-17 7:47 ` Yongqiang Yang
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Liu @ 2011-11-17 7:19 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, Zheng Liu
Fix ext4_debug format in ext4_ext_handle_uninitialized_extents() and
ext4_end_io_dio().
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
fs/ext4/extents.c | 4 ++--
fs/ext4/inode.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 61fa9e1..8e2a57c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3454,8 +3454,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode,
int err = 0;
ext4_io_end_t *io = EXT4_I(inode)->cur_aio_dio;
- ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical"
- "block %llu, max_blocks %u, flags %d, allocated %u",
+ ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical "
+ "block %llu, max_blocks %u, flags %d, allocated %u\n",
inode->i_ino, (unsigned long long)map->m_lblk, map->m_len,
flags, allocated);
ext4_ext_show_leaf(inode, path);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 240f6e2..4c037f9 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2775,7 +2775,7 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset,
if (!io_end || !size)
goto out;
- ext_debug("ext4_end_io_dio(): io_end 0x%p"
+ ext_debug("ext4_end_io_dio(): io_end 0x%p "
"for inode %lu, iocb 0x%p, offset %llu, size %llu\n",
iocb->private, io_end->inode->i_ino, iocb, offset,
size);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] [PATCH] ext4: fix ext4_debug format
2011-11-17 7:19 [PATCH 1/2] [PATCH] ext4: fix ext4_debug format Zheng Liu
@ 2011-11-17 7:47 ` Yongqiang Yang
2011-11-17 10:19 ` [PATCH v2] " Zheng Liu
0 siblings, 1 reply; 4+ messages in thread
From: Yongqiang Yang @ 2011-11-17 7:47 UTC (permalink / raw)
To: Zheng Liu; +Cc: linux-ext4, tytso, Zheng Liu
Hi Zheng,
On Thu, Nov 17, 2011 at 3:19 PM, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> Fix ext4_debug format in ext4_ext_handle_uninitialized_extents() and
> ext4_end_io_dio().
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
> fs/ext4/extents.c | 4 ++--
> fs/ext4/inode.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 61fa9e1..8e2a57c 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3454,8 +3454,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode,
> int err = 0;
> ext4_io_end_t *io = EXT4_I(inode)->cur_aio_dio;
>
> - ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical"
> - "block %llu, max_blocks %u, flags %d, allocated %u",
> + ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical "
> + "block %llu, max_blocks %u, flags %d, allocated %u\n",
> inode->i_ino, (unsigned long long)map->m_lblk, map->m_len,
> flags, allocated);
Could you format flags by %x instead of %d? The output will be more readable.
Yongqiang.
> ext4_ext_show_leaf(inode, path);
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 240f6e2..4c037f9 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2775,7 +2775,7 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset,
> if (!io_end || !size)
> goto out;
>
> - ext_debug("ext4_end_io_dio(): io_end 0x%p"
> + ext_debug("ext4_end_io_dio(): io_end 0x%p "
> "for inode %lu, iocb 0x%p, offset %llu, size %llu\n",
> iocb->private, io_end->inode->i_ino, iocb, offset,
> size);
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ext4: fix ext4_debug format
2011-11-17 7:47 ` Yongqiang Yang
@ 2011-11-17 10:19 ` Zheng Liu
2011-12-29 0:01 ` Ted Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Liu @ 2011-11-17 10:19 UTC (permalink / raw)
To: xiaoqiangnk; +Cc: tytso, linux-ext4, Zheng Liu
v1->v2:
* format flags by %x instead of %d for more readable
Fix ext4_debug format in ext4_ext_handle_uninitialized_extents() and
ext4_end_io_dio().
Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
fs/ext4/extents.c | 4 ++--
fs/ext4/inode.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 61fa9e1..f5d62d7 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3454,8 +3454,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode,
int err = 0;
ext4_io_end_t *io = EXT4_I(inode)->cur_aio_dio;
- ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical"
- "block %llu, max_blocks %u, flags %d, allocated %u",
+ ext_debug("ext4_ext_handle_uninitialized_extents: inode %lu, logical "
+ "block %llu, max_blocks %u, flags %x, allocated %u\n",
inode->i_ino, (unsigned long long)map->m_lblk, map->m_len,
flags, allocated);
ext4_ext_show_leaf(inode, path);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 240f6e2..4c037f9 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2775,7 +2775,7 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset,
if (!io_end || !size)
goto out;
- ext_debug("ext4_end_io_dio(): io_end 0x%p"
+ ext_debug("ext4_end_io_dio(): io_end 0x%p "
"for inode %lu, iocb 0x%p, offset %llu, size %llu\n",
iocb->private, io_end->inode->i_ino, iocb, offset,
size);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ext4: fix ext4_debug format
2011-11-17 10:19 ` [PATCH v2] " Zheng Liu
@ 2011-12-29 0:01 ` Ted Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Ted Ts'o @ 2011-12-29 0:01 UTC (permalink / raw)
To: Zheng Liu; +Cc: xiaoqiangnk, linux-ext4, Zheng Liu
On Thu, Nov 17, 2011 at 06:19:56PM +0800, Zheng Liu wrote:
> v1->v2:
> * format flags by %x instead of %d for more readable
>
> Fix ext4_debug format in ext4_ext_handle_uninitialized_extents() and
> ext4_end_io_dio().
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Applied with the patch summary: "ext4: add missing spaces to debugging
printk's".
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-29 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 7:19 [PATCH 1/2] [PATCH] ext4: fix ext4_debug format Zheng Liu
2011-11-17 7:47 ` Yongqiang Yang
2011-11-17 10:19 ` [PATCH v2] " Zheng Liu
2011-12-29 0:01 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).