From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH 00/10] extent-based bitmaps for e2fsprogs
Date: Sun, 18 Dec 2011 01:42:28 -0500 [thread overview]
Message-ID: <1324190558-7436-1-git-send-email-tytso@mit.edu> (raw)
I spent some time playing with Lukas Czerner's rbtree patches. Here is
a patch set which is based on the latest e2fsprogs sources, and which
doesn't break any library ABI's or API's. I also threw in regression
tester for bitmaps, and fixed a bug in rb_unmark_bmap() that was found
by the regression tests.
My tests on a number of file systems that I had easy access to seems to
indicate that on pretty much all file systems, using the rbtree based
implementation is a huge win over the bitarray. (With memory required
after patches being as low as 25% of the memory needed beforehand,
although I believe 40-50% of the memory required in previous releases is
more realistic.) The one exception is if there are a huge number of
directories, which is the reason for the AUTODIR pseudo backend.
Comments, please!
- Ted
Lukas Czerner (3):
libext2fs: add rbtree library
libext2fs: add a bitmap implementation using rbtree's
libext2fs: add bitmap statistics
Theodore Ts'o (7):
libext2fs: add default_bitmap_type to the ext2_filsys structure
libext2fs: add tests for the bitmap functions
libext2fs: add pseudo bitmap backend type EXT2FS_BMAP64_AUTODIR
e2fsck: fix pass5 bug when using two different bitmap backends
libext2fs: use the rbtree bitmap by default when initializing a file
system
e2fsck: use different bitmap types as appropriate
libext2fs: adjust the description when copying a bitmap
e2fsck/e2fsck.h | 20 +
e2fsck/pass1.c | 62 ++--
e2fsck/pass1b.c | 6 +-
e2fsck/pass2.c | 7 +-
e2fsck/pass3.c | 7 +-
e2fsck/pass5.c | 4 +-
e2fsck/unix.c | 4 +
e2fsck/util.c | 61 +++
lib/ext2fs/Makefile.in | 38 ++-
lib/ext2fs/bitmaps.c | 14 +-
lib/ext2fs/blkmap64_ba.c | 8 +
lib/ext2fs/blkmap64_rb.c | 824 +++++++++++++++++++++++++++++++++++++++++
lib/ext2fs/bmap64.h | 33 ++
lib/ext2fs/ext2fs.h | 15 +-
lib/ext2fs/ext2fsP.h | 2 -
lib/ext2fs/gen_bitmap64.c | 158 ++++++++-
lib/ext2fs/icount.c | 4 +-
lib/ext2fs/initialize.c | 1 +
lib/ext2fs/rbtree.c | 451 ++++++++++++++++++++++
lib/ext2fs/rbtree.h | 180 +++++++++
lib/ext2fs/tst_bitmaps.c | 577 ++++++++++++++++++++++++++++
lib/ext2fs/tst_bitmaps_cmd.ct | 39 ++
lib/ext2fs/tst_bitmaps_cmds | 46 +++
lib/ext2fs/tst_bitmaps_exp | 92 +++++
24 files changed, 2600 insertions(+), 53 deletions(-)
create mode 100644 lib/ext2fs/blkmap64_rb.c
create mode 100644 lib/ext2fs/rbtree.c
create mode 100644 lib/ext2fs/rbtree.h
create mode 100644 lib/ext2fs/tst_bitmaps.c
create mode 100644 lib/ext2fs/tst_bitmaps_cmd.ct
create mode 100644 lib/ext2fs/tst_bitmaps_cmds
create mode 100644 lib/ext2fs/tst_bitmaps_exp
--
1.7.8.11.gefc1f.dirty
next reply other threads:[~2011-12-18 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 6:42 Theodore Ts'o [this message]
2011-12-18 6:42 ` [PATCH 01/10] libext2fs: add default_bitmap_type to the ext2_filsys structure Theodore Ts'o
2011-12-18 6:42 ` [PATCH 02/10] libext2fs: add tests for the bitmap functions Theodore Ts'o
2011-12-19 10:59 ` Lukas Czerner
2011-12-18 6:42 ` [PATCH 03/10] libext2fs: add rbtree library Theodore Ts'o
2011-12-18 6:42 ` [PATCH 04/10] libext2fs: add a bitmap implementation using rbtree's Theodore Ts'o
2011-12-18 6:42 ` [PATCH 05/10] libext2fs: add pseudo bitmap backend type EXT2FS_BMAP64_AUTODIR Theodore Ts'o
2011-12-19 11:16 ` Lukas Czerner
2011-12-18 6:42 ` [PATCH 06/10] e2fsck: fix pass5 bug when using two different bitmap backends Theodore Ts'o
2011-12-18 6:42 ` [PATCH 07/10] libext2fs: use the rbtree bitmap by default when initializing a file system Theodore Ts'o
2011-12-19 14:15 ` Lukas Czerner
2011-12-19 14:17 ` Lukas Czerner
2011-12-18 6:42 ` [PATCH 08/10] e2fsck: use different bitmap types as appropriate Theodore Ts'o
2011-12-18 6:42 ` [PATCH 09/10] libext2fs: adjust the description when copying a bitmap Theodore Ts'o
2011-12-18 6:42 ` [PATCH 10/10] libext2fs: add bitmap statistics Theodore Ts'o
2011-12-19 11:43 ` Lukas Czerner
2011-12-19 8:50 ` [PATCH 00/10] extent-based bitmaps for e2fsprogs Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324190558-7436-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).