From: Andrei Popa <andrei.popa@i-neo.ro>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: ext4 discard does not apper in /proc/mounts
Date: Mon, 09 Jan 2012 21:23:23 +0200 [thread overview]
Message-ID: <1326137003.2092.1.camel@ierdnac-hp> (raw)
In-Reply-To: <4F0B1FF8.8010200@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Mon, 2012-01-09 at 11:12 -0600, Eric Sandeen wrote:
> What kernel?
ierdnac-hp ~ # uname -a
Linux ierdnac-hp 3.1.6-pf-c220 #1 SMP PREEMPT Mon Jan 2 12:59:38 EET
2012 x86_64 Intel(R) Core(TM) i3 CPU M 380 @ 2.53GHz GenuineIntel
GNU/Linux
> If it's a recent kernel, here is the logic which controls whether to show it:
>
> if (test_opt(sb, DISCARD) && !(def_mount_opts & EXT4_DEFM_DISCARD))
> seq_puts(seq, ",discard");
>
> i.e. if "discard" is in the default mount options for the fs, it is not
> shown, by design - although I am not 100% sure why that design decision
> was made; that logic was explicitly added here:
Indeed:
ierdnac-hp ~ # tune2fs -l /dev/sda3|grep discard
ierdnac-hp ~ #
ierdnac-hp ~ # cat /proc/mounts |grep discard
/dev/root / ext4 rw,noatime,errors=remount-ro,user_xattr,acl,barrier=0,data=writeback,discard 0 0
Thank you for clarifing this !
--
Andrei Popa
(+4) 0741.57.80.90
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4496 bytes --]
prev parent reply other threads:[~2012-01-09 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 23:23 ext4 discard does not apper in /proc/mounts Andrei Popa
2012-01-09 17:12 ` Eric Sandeen
2012-01-09 19:23 ` Andrei Popa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326137003.2092.1.camel@ierdnac-hp \
--to=andrei.popa@i-neo.ro \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).