linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: adilger@gmail.com, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH 2/4] ext4: fix a bug in resize when first_data_block != 0
Date: Mon, 30 Jan 2012 00:01:04 +0800	[thread overview]
Message-ID: <1327852866-4448-3-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1327852866-4448-1-git-send-email-xiaoqiangnk@gmail.com>

ext4_group_first_block_no should be used to computer block offset and
first block no in group rather than group * block_per_group. Otherwise,
if first_data_block != 0, the result is wrong.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 fs/ext4/resize.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 9a6fb74..58109fa 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -956,7 +956,6 @@ static void update_backups(struct super_block *sb,
 {
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
 	const ext4_group_t last = sbi->s_groups_count;
-	const int bpg = EXT4_BLOCKS_PER_GROUP(sb);
 	unsigned three = 1;
 	unsigned five = 5;
 	unsigned seven = 7;
@@ -982,7 +981,8 @@ static void update_backups(struct super_block *sb,
 		    (err = ext4_journal_restart(handle, EXT4_MAX_TRANS_DATA)))
 			break;
 
-		bh = sb_getblk(sb, group * bpg + blk_off);
+		bh = sb_getblk(sb, ext4_group_first_block_no(sb, group) +
+				   blk_off);
 		if (!bh) {
 			err = -EIO;
 			break;
@@ -1291,15 +1291,17 @@ exit_journal:
 
 	if (!err) {
 		int i;
-		update_backups(sb, sbi->s_sbh->b_blocknr, (char *)es,
-			       sizeof(struct ext4_super_block));
+		ext4_fsblk_t first_block;
+		first_block = ext4_group_first_block_no(sb, 0);
+		update_backups(sb, sbi->s_sbh->b_blocknr - first_block,
+			       (char *)es, sizeof(struct ext4_super_block));
 		for (i = 0; i < flex_gd->count; i++, group++) {
 			struct buffer_head *gdb_bh;
 			int gdb_num;
 			gdb_num = group / EXT4_BLOCKS_PER_GROUP(sb);
 			gdb_bh = sbi->s_group_desc[gdb_num];
-			update_backups(sb, gdb_bh->b_blocknr, gdb_bh->b_data,
-				       gdb_bh->b_size);
+			update_backups(sb, gdb_bh->b_blocknr - first_block,
+				       gdb_bh->b_data, gdb_bh->b_size);
 		}
 	}
 exit:
-- 
1.7.5.1


  parent reply	other threads:[~2012-03-22 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29 16:01 ext4: add meta_bg and bit64 support to online resizing Yongqiang Yang
2012-01-29 16:01 ` [PATCH 1/4] ext4: do not copy gdt blocks for groups which do not have super when resizing Yongqiang Yang
2012-01-29 16:01 ` Yongqiang Yang [this message]
2012-01-29 16:01 ` [PATCH 3/4] ext4: accelerate updating of backup gdb Yongqiang Yang
2012-01-29 16:01 ` [PATCH 4/4] ext4: enable online-resizing support meta_bg and bit64 Yongqiang Yang
2012-03-22 16:00   ` Andreas Dilger
2012-03-23 18:02 ` ext4: add meta_bg and bit64 support to online resizing Anssi Hannula
2012-04-14 14:55   ` Anssi Hannula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327852866-4448-3-git-send-email-xiaoqiangnk@gmail.com \
    --to=xiaoqiangnk@gmail.com \
    --cc=adilger@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).