From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 0/8 v3] Checkpointing fixes and cleanups
Date: Wed, 15 Feb 2012 19:34:06 +0100 [thread overview]
Message-ID: <1329330854-14237-1-git-send-email-jack@suse.cz> (raw)
Hello,
this is a third round of my checkpointing fixes. The patch set is primarily
aimed at fixing filesystem corruption happening occasionally (rather rarely)
after power failure. First three patches should fix the issue. Patches 4-7 are
assorted checkpointing cleanups I've gathered when inspecting checkpointing
code. Finally patch 8 is a possible speedup of checkpoining - we can use cache
flushes happening during transaction commits for pushing the journal tail
safely. The observable speedup is disputable since jbd2_cleanup_journal_tail()
is called rather rarely (for metadata heavy load I saw about one
jbd2_cleanup_journal_tail() for about 200 commits) so the cost of additional
cache flush will be likely in the noise. But the patch is simple enough so I
send it for others to judge whether it makes sense or not.
Changes since v2:
Rewrote the code pushing log tail to fix race described by Ted.
Improved some comments
Honza
next reply other threads:[~2012-02-15 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:34 Jan Kara [this message]
2012-02-15 18:34 ` [PATCH 1/8] jbd2: Split updating of journal superblock and marking journal empty Jan Kara
2012-02-15 18:34 ` [PATCH 2/8] jbd2: Protect all log tail updates with j_checkpoint_mutex Jan Kara
2012-02-15 18:34 ` [PATCH 3/8] jbd2: Issue cache flush after checkpointing even with internal journal Jan Kara
2012-03-14 2:17 ` Ted Ts'o
2012-03-15 8:59 ` Jan Kara
2012-03-19 3:45 ` Ted Ts'o
2012-02-15 18:34 ` [PATCH 4/8] jbd2: Fix BH_JWrite setting in checkpointing code Jan Kara
2012-02-15 18:34 ` [PATCH 5/8] jbd2: __jbd2_journal_temp_unlink_buffer() is static Jan Kara
2012-02-15 18:34 ` [PATCH 6/8] jbd2: Remove always true condition in __journal_try_to_free_buffer() Jan Kara
2012-02-15 18:34 ` [PATCH 7/8] jbd2: Remove bh_state lock from checkpointing code Jan Kara
2012-02-15 18:34 ` [PATCH 8/8] jbd2: Cleanup journal tail after transaction commit Jan Kara
2012-02-15 22:03 ` Andreas Dilger
2012-02-16 12:59 ` Jan Kara
2012-02-29 11:03 ` [PATCH 0/8 v3] Checkpointing fixes and cleanups Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329330854-14237-1-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).