From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>, Tom Gundersen <teg@jklm.no>,
Thomas Baechler <thomas@archlinux.org>,
Tobias Powalowski <tobias.powalowski@googlemail.com>,
Dave Reisner <d@falconindy.com>
Subject: [PATCH 10/11] ext4: ignore mount options supported by ext2/3 (but have since been removed)
Date: Sun, 4 Mar 2012 22:08:24 -0500 [thread overview]
Message-ID: <1330916905-5976-10-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1330916905-5976-1-git-send-email-tytso@mit.edu>
Users who tried to use the ext4 file system driver is being used for
the ext2 or ext3 file systems (via the CONFIG_EXT4_USE_FOR_EXT23
option) could have failed mounts if their /etc/fstab contains options
recognized by ext2 or ext3 but which have since been removed in ext4.
So teach ext4 to recognize them and give a warning that the mount
option was removed.
Report: https://bbs.archlinux.org/profile.php?id=33804
Signed-off-by: Tom Gundersen <teg@jklm.no>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Thomas Baechler <thomas@archlinux.org>
Cc: Tobias Powalowski <tobias.powalowski@googlemail.com>
Cc: Dave Reisner <d@falconindy.com>
---
fs/ext4/super.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 27d490d..960681f 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1249,6 +1249,11 @@ static const match_table_t tokens = {
{Opt_init_itable, "init_itable=%u"},
{Opt_init_itable, "init_itable"},
{Opt_noinit_itable, "noinit_itable"},
+ {Opt_removed, "check=none"}, /* mount option from ext2/3 */
+ {Opt_removed, "nocheck"}, /* mount option from ext2/3 */
+ {Opt_removed, "reservation"}, /* mount option from ext2/3 */
+ {Opt_removed, "noreservation"}, /* mount option from ext2/3 */
+ {Opt_removed, "journal=%u"}, /* mount option from ext2/3 */
{Opt_err, NULL},
};
--
1.7.9.107.g97f9a
next prev parent reply other threads:[~2012-03-05 3:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 3:08 [PATCH 01/11] ext4: remove deprecation warnings for minix_df and grpid Theodore Ts'o
2012-03-05 3:08 ` [PATCH 02/11] ext4: remove Opt_ignore Theodore Ts'o
2012-03-05 3:08 ` [PATCH 03/11] ext4: remove the I_VERSION mount flag and use the super_block flag instead Theodore Ts'o
2012-03-05 3:08 ` [PATCH 04/11] ext4: simplify handling of the errors=* mount options Theodore Ts'o
2012-03-05 3:08 ` [PATCH 05/11] ext4: unify handling of mount options which have been removed Theodore Ts'o
2012-03-05 3:08 ` [PATCH 06/11] ext4: use a table-driven handler for mount options Theodore Ts'o
2012-03-05 3:08 ` [PATCH 07/11] ext4: move ext4_show_options() after parse_options() Theodore Ts'o
2012-03-05 3:08 ` [PATCH 08/11] ext4: make ext4_show_options() be table-driven Theodore Ts'o
2012-03-05 3:08 ` [PATCH 09/11] ext4: add debugging /proc file showing file system options Theodore Ts'o
2012-03-05 3:08 ` Theodore Ts'o [this message]
2012-03-05 3:08 ` [PATCH 11/11] ext4: try to deprecate noacl and noxattr_user mount options Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330916905-5976-10-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=d@falconindy.com \
--cc=linux-ext4@vger.kernel.org \
--cc=teg@jklm.no \
--cc=thomas@archlinux.org \
--cc=tobias.powalowski@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).