From: Tim Chen <tim.c.chen@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>, Ted Ts'o <tytso@mit.edu>,
Vivek Haldar <haldar@google.com>,
Andreas Dilger <adilger@dilger.ca>,
linux-ext4@vger.kernel.org
Subject: Re: [RFC, PATCH] Avoid hot statistics cache line in ext4 extent cache
Date: Fri, 13 Apr 2012 10:53:32 -0700 [thread overview]
Message-ID: <1334339612.3796.2.camel@schen9-DESK> (raw)
In-Reply-To: <CA+55aFx8UsBEqK2KA_7D4YNGYrtcNaduvuEUcLfbRRjSXS_Xeg@mail.gmail.com>
On Fri, 2012-04-13 at 10:42 -0700, Linus Torvalds wrote:
> On Wed, Apr 11, 2012 at 9:59 AM, Andi Kleen <andi@firstfloor.org> wrote:
> >
> > Ping. This scalability problem is still in 3.4-rc* and causes
> > major slowdowns.
>
> Do you have numbers?
>
In a benchmark that does mmaped-read, there is a 28% speed up
after getting rid of the counters.
> > Can we please revert fix it or revert
> > 556b27abf73833923d5cd4be80006292e1b31662 before release.
>
> That commit ID doesn't make any sense, and doesn't seem to have
> anything to do with any statistics counters that your email talks
> about. So regardless, you'd need to explain why that commit causes the
> problems you talk about, I'm not going to revert a random commit that
> doesn't even look what you describe.
>
> Ted?
>
> Linus
next prev parent reply other threads:[~2012-04-13 17:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 22:17 [RFC, PATCH] Avoid hot statistics cache line in ext4 extent cache Andi Kleen
2012-03-24 1:10 ` Andreas Dilger
2012-03-24 3:13 ` Andi Kleen
2012-03-26 22:26 ` Vivek Haldar
2012-03-26 23:00 ` Andi Kleen
2012-03-26 23:57 ` Ted Ts'o
2012-04-11 16:59 ` Andi Kleen
2012-04-13 17:42 ` Linus Torvalds
2012-04-13 17:53 ` Tim Chen [this message]
2012-04-13 18:08 ` Linus Torvalds
2012-04-13 18:31 ` Tim Chen
2012-04-13 18:33 ` Linus Torvalds
2012-04-13 18:37 ` Ted Ts'o
2012-04-13 18:41 ` Andi Kleen
2012-04-13 18:48 ` Ted Ts'o
2012-04-13 19:01 ` Eric Whitney
2012-04-13 19:26 ` Tim Chen
2012-04-13 19:33 ` Ted Ts'o
2012-04-13 17:57 ` Andi Kleen
2012-04-13 18:06 ` Ted Ts'o
2012-04-13 18:22 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334339612.3796.2.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=adilger@dilger.ca \
--cc=andi@firstfloor.org \
--cc=haldar@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).