From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: ksumrall@google.com, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH 0/5] Clean up I/O buffer allocation in e2fsprogs
Date: Mon, 7 May 2012 14:56:20 -0400 [thread overview]
Message-ID: <1336416985-24605-1-git-send-email-tytso@mit.edu> (raw)
Andreas pointed out that original version of the last patch in this
series would break the 16k/64k blocksize regressiont tests on MacOS
10.5. When I looked into addressing this, I realized that we didn't
need to request 16k or 64k alignment, and in general we often requested
aligned buffers when they were not necessary, and/or requested a larger
alignment factor than necessary.
This patch series cleans up this mess by refactoring the code so that
DIO alignment is calculated in one place, and so we have a common
routine for allocating I/O buffers used by e2fsprogs's I/O layer.
- Ted
Theodore Ts'o (5):
libext2fs: move the alignment field from unix_io to the io_manager
libext2fs: refactor Direct I/O alignment requirement calculations
libext2fs: make read_bitmaps() more efficient when using direct I/O
libext2fs: factor out I/O buffer allocation
Support systems without posix_memalign() and memalign()
lib/ext2fs/Makefile.in | 9 +++++++-
lib/ext2fs/ext2_io.h | 3 +++
lib/ext2fs/ext2fs.h | 1 +
lib/ext2fs/getsectsize.c | 26 +++++++++++++++++++++
lib/ext2fs/inline.c | 56 ++++++++++++++++++++++++++++++++++++++++++++--
lib/ext2fs/inode.c | 4 ++--
lib/ext2fs/io_manager.c | 17 ++++++++++++++
lib/ext2fs/mmp.c | 37 ++++++++----------------------
lib/ext2fs/openfs.c | 2 +-
lib/ext2fs/rw_bitmaps.c | 24 ++++++++------------
lib/ext2fs/test_io.c | 7 +++++-
lib/ext2fs/unix_io.c | 42 +++++++++++++++-------------------
12 files changed, 154 insertions(+), 74 deletions(-)
--
1.7.10.rc3
next reply other threads:[~2012-05-07 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 18:56 Theodore Ts'o [this message]
2012-05-07 18:56 ` [PATCH 1/5] libext2fs: move the alignment field from unix_io to the io_manager Theodore Ts'o
2012-05-07 18:56 ` [PATCH 2/5] libext2fs: refactor Direct I/O alignment requirement calculations Theodore Ts'o
2012-05-07 18:56 ` [PATCH 3/5] libext2fs: make read_bitmaps() more efficient when using direct I/O Theodore Ts'o
2012-05-07 18:56 ` [PATCH 4/5] libext2fs: factor out I/O buffer allocation Theodore Ts'o
2012-05-07 18:56 ` [PATCH 5/5] Support systems without posix_memalign() and memalign() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336416985-24605-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=ksumrall@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).