From: Tao Ma <tm@tao.ma>
To: linux-ext4@vger.kernel.org
Subject: [PATCH 1/2] e2fsck: Let end_blk to be the maximum value of u32.
Date: Thu, 17 May 2012 15:16:06 +0800 [thread overview]
Message-ID: <1337238967-4704-2-git-send-email-tm@tao.ma> (raw)
In-Reply-To: <1337238967-4704-1-git-send-email-tm@tao.ma>
From: Tao Ma <boyu.mt@taobao.com>
Now we can use fallocate to create a large file while keep the size
to be small. It will cause the e2fsck complain about it. The test
script is simple and I have pasted it here.
DEVICE=/dev/sdb1
mount -t ext4 $DEVICE /mnt/ext4
for((i=0;i<10;i++))do fallocate -n -o $[$i*8192] -l 4096 /mnt/ext4/a;done
umount $DEVICE
e2fsck -fn $DEVICE
The error message will be like this:
e2fsck 1.42.3 (14-May-2012)
Pass 1: Checking inodes, blocks, and sizes
Inode 12 has zero length extent
(invalid logical block 0, physical block 32775)
Clear? no
Inode 12, i_blocks is 88, should be 0. Fix? no
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information
Block bitmap differences: -(8231--8232) -(32770--32778)
Fix? no
Now actually the end_blk can be any value which is less than
u32, so make end_blk be the maximum value of u32.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
lib/ext2fs/extent.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/lib/ext2fs/extent.c b/lib/ext2fs/extent.c
index eb096d6..e2815c2 100644
--- a/lib/ext2fs/extent.c
+++ b/lib/ext2fs/extent.c
@@ -253,9 +253,7 @@ extern errcode_t ext2fs_extent_open2(ext2_filsys fs, ext2_ino_t ino,
ext2fs_le16_to_cpu(eh->eh_entries);
handle->path[0].max_entries = ext2fs_le16_to_cpu(eh->eh_max);
handle->path[0].curr = 0;
- handle->path[0].end_blk =
- (EXT2_I_SIZE(handle->inode) + fs->blocksize - 1) >>
- EXT2_BLOCK_SIZE_BITS(fs->super);
+ handle->path[0].end_blk = ((((unsigned long long) 1) << 32) - 1);
handle->path[0].visit_num = 1;
handle->level = 0;
handle->magic = EXT2_ET_MAGIC_EXTENT_HANDLE;
--
1.7.1
next prev parent reply other threads:[~2012-05-17 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 7:16 [PATCH 0/2 V2] Fix an e2fsck bug for fallocated extent Tao Ma
2012-05-17 7:16 ` Tao Ma [this message]
2012-06-11 5:02 ` [PATCH 1/2] e2fsck: Let end_blk to be the maximum value of u32 Ted Ts'o
2012-05-17 7:16 ` [PATCH 2/2] e2fsck/tests: Add the regression test case for e2fsck Tao Ma
2012-06-11 5:07 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337238967-4704-2-git-send-email-tm@tao.ma \
--to=tm@tao.ma \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).