linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saugata Das <saugata.das@stericsson.com>
To: <linux-ext4@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<patches@linaro.org>
Cc: <arnd.bergmann@linaro.org>, <venkat@linaro.org>,
	<lporzio@micron.com>, <tytso@mit.edu>, <adilger@dilger.ca>,
	<hch@infradead.org>, <bharrosh@panasas.com>,
	<deepak.saxena@linaro.org>, Saugata Das <saugata.das@linaro.org>
Subject: [PATCH v2 1/2] block: add BH_Meta flag
Date: Thu, 17 May 2012 17:51:29 +0530	[thread overview]
Message-ID: <1337257290-28547-1-git-send-email-saugata.das@stericsson.com> (raw)

From: Saugata Das <saugata.das@linaro.org>

Today, storage devices like eMMC has special features like data tagging
(introduced in MMC-4.5 version) in order to improve performance of some
specific writes. On MMC stack, data tagging is used for all writes which
has REQ_META flag set. This patch adds the capability to add REQ_META flag
during meta data write.

Signed-off-by: Saugata Das <saugata.das@linaro.org>

changes in v2:
	Replaced the conditionals around submit_bh as suggested in the review
	comments from Boaz
---
 fs/buffer.c                 |    6 ++++--
 include/linux/buffer_head.h |    2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 36d6665..942c75b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1685,7 +1685,8 @@ static int __block_write_full_page(struct inode *inode, struct page *page,
 	do {
 		struct buffer_head *next = bh->b_this_page;
 		if (buffer_async_write(bh)) {
-			submit_bh(write_op, bh);
+			submit_bh(write_op |
+				(buffer_meta(bh) << __REQ_META), bh);
 			nr_underway++;
 		}
 		bh = next;
@@ -1739,7 +1740,8 @@ recover:
 		struct buffer_head *next = bh->b_this_page;
 		if (buffer_async_write(bh)) {
 			clear_buffer_dirty(bh);
-			submit_bh(write_op, bh);
+			submit_bh(write_op |
+				(buffer_meta(bh) << __REQ_META), bh);
 			nr_underway++;
 		}
 		bh = next;
diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
index 458f497..13bba17 100644
--- a/include/linux/buffer_head.h
+++ b/include/linux/buffer_head.h
@@ -34,6 +34,7 @@ enum bh_state_bits {
 	BH_Write_EIO,	/* I/O error on write */
 	BH_Unwritten,	/* Buffer is allocated on disk but not written */
 	BH_Quiet,	/* Buffer Error Prinks to be quiet */
+	BH_Meta,	/* Is meta */
 
 	BH_PrivateStart,/* not a state bit, but the first bit available
 			 * for private allocation by other entities
@@ -124,6 +125,7 @@ BUFFER_FNS(Delay, delay)
 BUFFER_FNS(Boundary, boundary)
 BUFFER_FNS(Write_EIO, write_io_error)
 BUFFER_FNS(Unwritten, unwritten)
+BUFFER_FNS(Meta, meta)
 
 #define bh_offset(bh)		((unsigned long)(bh)->b_data & ~PAGE_MASK)
 #define touch_buffer(bh)	mark_page_accessed(bh->b_page)
-- 
1.7.4.3


             reply	other threads:[~2012-05-17 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 12:21 Saugata Das [this message]
2012-05-17 12:21 ` [PATCH v2 2/2] ext4: annotate all meta data requests Saugata Das
2012-05-22  4:18 ` [PATCH v2 1/2] block: add BH_Meta flag Saugata Das
2012-05-22 16:37 ` Jeff Moyer
2012-05-28 14:30   ` Saugata Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337257290-28547-1-git-send-email-saugata.das@stericsson.com \
    --to=saugata.das@stericsson.com \
    --cc=adilger@dilger.ca \
    --cc=arnd.bergmann@linaro.org \
    --cc=bharrosh@panasas.com \
    --cc=deepak.saxena@linaro.org \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lporzio@micron.com \
    --cc=patches@linaro.org \
    --cc=saugata.das@linaro.org \
    --cc=tytso@mit.edu \
    --cc=venkat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).