From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/4] Avoid deadlock when corrupted directory creates a loop
Date: Tue, 29 May 2012 22:07:43 +0200 [thread overview]
Message-ID: <1338322067-17566-1-git-send-email-jack@suse.cz> (raw)
Hello,
Sami Liedes reported a problem that when a accessing a corrupted filesystem
the system deadlocks. The culprit is that the corruption has created a (self-)
loop in the directory hierarchy and thus we deadlock when trying to lock
i_mutex twice.
This patch set attempts at fixing the problem since it seems relatively
straightforward. We teach d_splice_alias() to fail when it would add the second
connected alias to a directory inode and then handle the failure in
filesystems. So far I've taugh ext? filesystems to handle the failure properly
but other filesystems should be similarly trivial. Just I'd like to hear
whether people agree to the general idea of the fix first.
Honza
next reply other threads:[~2012-05-29 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 20:07 Jan Kara [this message]
2012-05-29 20:07 ` [PATCH 1/4] vfs: Avoid creation of directory loops for corrupted filesystems Jan Kara
2012-05-29 20:07 ` [PATCH 2/4] ext2: Handle error from d_splice_alias() Jan Kara
2012-05-29 20:07 ` [PATCH 3/4] ext3: " Jan Kara
2012-05-29 20:07 ` [PATCH 4/4] ext4: " Jan Kara
2012-05-30 10:39 ` [PATCH 5/4] exofs: " Boaz Harrosh
2012-05-30 10:40 ` Boaz Harrosh
2012-06-08 21:59 ` Al Viro
2012-06-11 15:41 ` Boaz Harrosh
2012-06-11 19:01 ` Ted Ts'o
2012-06-12 9:04 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338322067-17566-1-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).