From: Haibo <haiboliu6@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: Haibo Liu <HaiboLiu6@gmai.com>, Haibo Liu <HaiboLiu6@gmail.com>
Subject: [PATCH][v2] ext4: delete a no useful sentence
Date: Fri, 22 Jun 2012 02:31:06 +0800 [thread overview]
Message-ID: <1340303466-7967-1-git-send-email-HaiboLiu6@gmail.com> (raw)
From: Haibo Liu <HaiboLiu6@gmai.com>
In this patch, the sentence "poff = block % blocks_per_page"
in ext4_mb_get_buddy_page_lock has no effect.
So we should delete it to save cpu.
v1->v2: update the patch subject and the patch comment.
Signed-off-by: Haibo Liu <HaiboLiu6@gmail.com>
---
fs/ext4/mballoc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index cb990b2..7223bd4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1016,7 +1016,6 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb,
block++;
pnum = block / blocks_per_page;
- poff = block % blocks_per_page;
page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS);
if (!page)
return -EIO;
--
1.7.9.5
next reply other threads:[~2012-06-21 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 18:31 Haibo [this message]
2012-07-09 14:25 ` [v2] ext4: delete a no useful sentence Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340303466-7967-1-git-send-email-HaiboLiu6@gmail.com \
--to=haiboliu6@gmail.com \
--cc=HaiboLiu6@gmai.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).