* [PATCH][v2] ext4: delete a no useful sentence
@ 2012-06-21 18:31 Haibo
2012-07-09 14:25 ` [v2] " Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Haibo @ 2012-06-21 18:31 UTC (permalink / raw)
To: linux-ext4; +Cc: Haibo Liu, Haibo Liu
From: Haibo Liu <HaiboLiu6@gmai.com>
In this patch, the sentence "poff = block % blocks_per_page"
in ext4_mb_get_buddy_page_lock has no effect.
So we should delete it to save cpu.
v1->v2: update the patch subject and the patch comment.
Signed-off-by: Haibo Liu <HaiboLiu6@gmail.com>
---
fs/ext4/mballoc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index cb990b2..7223bd4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1016,7 +1016,6 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb,
block++;
pnum = block / blocks_per_page;
- poff = block % blocks_per_page;
page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS);
if (!page)
return -EIO;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] ext4: delete a no useful sentence
2012-06-21 18:31 [PATCH][v2] ext4: delete a no useful sentence Haibo
@ 2012-07-09 14:25 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2012-07-09 14:25 UTC (permalink / raw)
To: Liu Haibo; +Cc: linux-ext4, Haibo Liu
On Thu, Jun 21, 2012 at 08:31:06AM -0000, Liu Haibo wrote:
> From: Haibo Liu <HaiboLiu6@gmai.com>
>
> In this patch, the sentence "poff = block % blocks_per_page"
> in ext4_mb_get_buddy_page_lock has no effect.
> So we should delete it to save cpu.
>
> v1->v2: update the patch subject and the patch comment.
>
> Signed-off-by: Haibo Liu <HaiboLiu6@gmail.com>
Applied, thanks. BTW, I modified the patch description a little to
note that the compiler would optimize out the statement, but it's
better to remove unused C statements.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-09 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 18:31 [PATCH][v2] ext4: delete a no useful sentence Haibo
2012-07-09 14:25 ` [v2] " Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).