From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: jack@suse.cz
Cc: linux-ext4@vger.kernel.org, Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: [PATCH] ext2: cleanup the confused goto label
Date: Sun, 24 Jun 2012 10:51:43 +0800 [thread overview]
Message-ID: <1340506303-31723-1-git-send-email-gaowanlong@cn.fujitsu.com> (raw)
Cleanup the confused goto label in ext2_fill_super.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
fs/ext2/super.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index b3621cb..301379d 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -771,14 +771,13 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
err = -ENOMEM;
sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
if (!sbi)
- goto failed_unlock;
+ goto failed;
sbi->s_blockgroup_lock =
kzalloc(sizeof(struct blockgroup_lock), GFP_KERNEL);
- if (!sbi->s_blockgroup_lock) {
- kfree(sbi);
- goto failed_unlock;
- }
+ if (!sbi->s_blockgroup_lock)
+ goto failed_sbi;
+
sb->s_fs_info = sbi;
sbi->s_sb_block = sb_block;
@@ -794,7 +793,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
blocksize = sb_min_blocksize(sb, BLOCK_SIZE);
if (!blocksize) {
ext2_msg(sb, KERN_ERR, "error: unable to set blocksize");
- goto failed_sbi;
+ goto failed_bg_lock;
}
/*
@@ -810,7 +809,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
if (!(bh = sb_bread(sb, logic_sb_block))) {
ext2_msg(sb, KERN_ERR, "error: unable to read superblock");
- goto failed_sbi;
+ goto failed_bg_lock;
}
/*
* Note: s_es must be initialized as soon as possible because
@@ -905,7 +904,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
if (!sb_set_blocksize(sb, blocksize)) {
ext2_msg(sb, KERN_ERR,
"error: bad blocksize %d", blocksize);
- goto failed_sbi;
+ goto failed_bg_lock;
}
logic_sb_block = (sb_block*BLOCK_SIZE) / blocksize;
@@ -914,7 +913,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
if(!bh) {
ext2_msg(sb, KERN_ERR, "error: couldn't read"
"superblock on 2nd try");
- goto failed_sbi;
+ goto failed_bg_lock;
}
es = (struct ext2_super_block *) (((char *)bh->b_data) + offset);
sbi->s_es = es;
@@ -1126,11 +1125,12 @@ failed_mount_group_desc:
kfree(sbi->s_debts);
failed_mount:
brelse(bh);
-failed_sbi:
+failed_bg_lock:
sb->s_fs_info = NULL;
kfree(sbi->s_blockgroup_lock);
+failed_sbi:
kfree(sbi);
-failed_unlock:
+failed:
return ret;
}
--
1.7.11.rc0
next reply other threads:[~2012-06-24 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 2:51 Wanlong Gao [this message]
2012-06-27 16:29 ` [PATCH] ext2: cleanup the confused goto label Jan Kara
2012-06-27 16:49 ` Wanlong Gao
2012-06-27 17:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340506303-31723-1-git-send-email-gaowanlong@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).