linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: linux-ext4@vger.kernel.org
Subject: [PATCH V5 01/23] ext4: Move extra inode read to a new function.
Date: Sat, 30 Jun 2012 23:45:02 +0800	[thread overview]
Message-ID: <1341071124-4976-1-git-send-email-tm@tao.ma> (raw)
In-Reply-To: <1341070917-4889-1-git-send-email-tm@tao.ma>

From: Tao Ma <boyu.mt@taobao.com>

Currently, in ext4_iget we do a simple check to see whether
there does exist some information starting from the end
of i_extra_size. With inline data added, this procedure
is more complicated. So move it to a new function named
ext4_iget_extra_inode.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/ext4/inode.c |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 02bc8cb..21793ea 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3687,6 +3687,16 @@ static blkcnt_t ext4_inode_blocks(struct ext4_inode *raw_inode,
 	}
 }
 
+static inline void ext4_iget_extra_inode(struct inode *inode,
+					 struct ext4_inode *raw_inode,
+					 struct ext4_inode_info *ei)
+{
+	__le32 *magic = (void *)raw_inode +
+			EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize;
+	if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC))
+		ext4_set_inode_state(inode, EXT4_STATE_XATTR);
+}
+
 struct inode *ext4_iget(struct super_block *sb, unsigned long ino)
 {
 	struct ext4_iloc iloc;
@@ -3829,11 +3839,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino)
 			ei->i_extra_isize = sizeof(struct ext4_inode) -
 					    EXT4_GOOD_OLD_INODE_SIZE;
 		} else {
-			__le32 *magic = (void *)raw_inode +
-					EXT4_GOOD_OLD_INODE_SIZE +
-					ei->i_extra_isize;
-			if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC))
-				ext4_set_inode_state(inode, EXT4_STATE_XATTR);
+			ext4_iget_extra_inode(inode, raw_inode, ei);
 		}
 	}
 
-- 
1.7.0.4


  reply	other threads:[~2012-06-30 15:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-30 15:41 [PATCH V5 00/23] ext4: Add inline data support Tao Ma
2012-06-30 15:45 ` Tao Ma [this message]
2012-06-30 15:45   ` [PATCH V5 02/23] ext4: export inline xattr functions Tao Ma
2012-06-30 15:45   ` [PATCH V5 03/23] ext4: Add the basic function for inline data support Tao Ma
2012-06-30 15:45   ` [PATCH V5 04/23] ext4: Add read support for inline data Tao Ma
2012-06-30 15:45   ` [PATCH V5 05/23] ext4: Add normal write " Tao Ma
2012-06-30 15:45   ` [PATCH V5 06/23] ext4: Add journalled " Tao Ma
2012-06-30 15:45   ` [PATCH V5 07/23] ext4: Add delalloc " Tao Ma
2012-06-30 15:45   ` [PATCH V5 08/23] ext4: Create a new function ext4_init_new_dir Tao Ma
2012-06-30 15:45   ` [PATCH V5 09/23] ext4: Refactor __ext4_check_dir_entry to accepts start and size Tao Ma
2012-06-30 15:45   ` [PATCH V5 10/23] ext4: Create __ext4_insert_dentry for dir entry insertion Tao Ma
2012-06-30 15:45   ` [PATCH V5 11/23] ext4: let add_dir_entry handle inline data properly Tao Ma
2012-06-30 15:45   ` [PATCH V5 12/23] ext4: Let ext4_readdir handle inline data Tao Ma
2012-06-30 15:45   ` [PATCH V5 13/23] ext4: Create a new function search_dir Tao Ma
2012-06-30 15:45   ` [PATCH V5 14/23] ext4: let ext4_find_entry handle inline data Tao Ma
2012-06-30 15:45   ` [PATCH V5 15/23] ext4: make ext4_delete_entry generic Tao Ma
2012-06-30 15:45   ` [PATCH V5 16/23] ext4: let ext4_delete_entry handle inline data Tao Ma
2012-06-30 15:45   ` [PATCH V5 17/23] ext4: let empty_dir handle inline dir Tao Ma
2012-06-30 15:45   ` [PATCH V5 18/23] ext4: let ext4_rename " Tao Ma
2012-06-30 15:45   ` [PATCH V5 19/23] ext4: Let fiemap work with inline data Tao Ma
2012-06-30 15:45   ` [PATCH V5 20/23] ext4: Evict inline data out if we needs to strore xattr in inode Tao Ma
2012-06-30 15:45   ` [PATCH V5 21/23] ext4: let ext4_truncate handle inline data correctly Tao Ma
2012-06-30 15:45   ` [PATCH V5 22/23] ext4: let fallocate " Tao Ma
2012-06-30 15:45   ` [PATCH V5 23/23] ext4: Enable ext4 inline support Tao Ma
2012-08-13 15:04 ` [PATCH V5 00/23] ext4: Add inline data support Theodore Ts'o
2012-08-14  2:43   ` Andreas Dilger
2012-08-14  7:04   ` Tao Ma
2012-08-14 15:19     ` Theodore Ts'o
2012-08-15  2:51       ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341071124-4976-1-git-send-email-tm@tao.ma \
    --to=tm@tao.ma \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).