From: Anatol Pomozov <anatol.pomozov@gmail.com>
To: tytso@mit.edu, linux-ext4@vger.kernel.org
Cc: dmonakhov@openvz.org, Anatol Pomozov <anatol.pomozov@gmail.com>
Subject: [PATCH 1/2] Make orphan functions no-op in no-journal mode
Date: Mon, 17 Sep 2012 10:47:16 -0700 [thread overview]
Message-ID: <1347904037-24229-1-git-send-email-anatol.pomozov@gmail.com> (raw)
This avoids using shared mutext and thus improves scalability of
no-journal mode. The goal of this change is similar to 3d287de3b828
but it avoids mutex usage for all ext4_orphan_del(NULL,..) calls.
Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
---
fs/ext4/namei.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 2a42cc0..6863cdf 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2362,6 +2362,8 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode)
struct ext4_iloc iloc;
int err = 0, rc;
+ if (!EXT4_SB(sb)->s_journal)
+ return 0;
if (!ext4_handle_valid(handle))
return 0;
@@ -2436,6 +2438,8 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode)
struct ext4_iloc iloc;
int err = 0;
+ if (!EXT4_SB(inode->i_sb)->s_journal)
+ return 0;
/* ext4_handle_valid() assumes a valid handle_t pointer */
if (handle && !ext4_handle_valid(handle))
return 0;
@@ -2456,7 +2460,7 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode)
* transaction handle with which to update the orphan list on
* disk, but we still need to remove the inode from the linked
* list in memory. */
- if (sbi->s_journal && !handle)
+ if (!handle)
goto out;
err = ext4_reserve_inode_write(handle, inode, &iloc);
--
1.7.12
next reply other threads:[~2012-09-17 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 17:47 Anatol Pomozov [this message]
2012-09-17 17:47 ` [PATCH 2/2] Extract 'ext4_sb_info' variable Anatol Pomozov
2012-09-17 17:55 ` [PATCH 1/2] Make orphan functions no-op in no-journal mode Anatol Pomozov
2012-09-18 3:32 ` Theodore Ts'o
2012-09-18 15:53 ` [PATCH] " Anatol Pomozov
2012-09-18 17:48 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347904037-24229-1-git-send-email-anatol.pomozov@gmail.com \
--to=anatol.pomozov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).