linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH REGRESSION FIX] ext4: fix mtime update in nodelalloc mode
@ 2012-09-30 19:48 Theodore Ts'o
  2012-09-30 19:50 ` Jonathan Nieder
       [not found] ` <1349034499-4731-1-git-send-email-tytso-3s7WtUTddSA@public.gmane.org>
  0 siblings, 2 replies; 7+ messages in thread
From: Theodore Ts'o @ 2012-09-30 19:48 UTC (permalink / raw)
  To: Ext4 Developers List
  Cc: linux-nilfs, Theodore Ts'o, Jan Kara, KONISHI Ryusuke, stable

Commits 41c4d25f78c0 and 41c4d25f78c0 introduced a regression into
3.6-rc1 for ext4 in nodealloc mode, such that mtime updates would not
take place for files modified via mmap if the page was already in the
page cache.

The problem was that ext4_page_mkwrite() had a shortcut which would
avoid calling __block_page_mkwrite() under some circumstances, and the
above two commit transferred the responsibility of calling
file_update_time() to __block_page_mkwrite --- which woudln't get
called in some circumstances.

Since __block_page_mkwrite() only has three years,
block_page_mkwrite(), ext4_page_mkwrite, and nilfs_page_mkwrite(), the
best way to solve this is to move the responsibility for calling
file_update_time() to its caller.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>
Cc: KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp>
Cc: stable@vger.kernel.org
---

NOTE: Since this is a 3.6 regression, I may push this to Linus ahead of
the merge window, since it will also affect distibutions which use ext4
to mount ext3-formatted partitions.

 fs/buffer.c      | 13 +++++++------
 fs/ext4/inode.c  |  1 +
 fs/nilfs2/file.c |  1 +
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 9f6d2e4..1fe3968 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2318,12 +2318,6 @@ int __block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
 	loff_t size;
 	int ret;
 
-	/*
-	 * Update file times before taking page lock. We may end up failing the
-	 * fault so this update may be superfluous but who really cares...
-	 */
-	file_update_time(vma->vm_file);
-
 	lock_page(page);
 	size = i_size_read(inode);
 	if ((page->mapping != inode->i_mapping) ||
@@ -2361,6 +2355,13 @@ int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
 	struct super_block *sb = vma->vm_file->f_path.dentry->d_inode->i_sb;
 
 	sb_start_pagefault(sb);
+
+	/*
+	 * Update file times before taking page lock. We may end up failing the
+	 * fault so this update may be superfluous but who really cares...
+	 */
+	file_update_time(vma->vm_file);
+
 	ret = __block_page_mkwrite(vma, vmf, get_block);
 	sb_end_pagefault(sb);
 	return block_page_mkwrite_return(ret);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 09308ad..f18e786 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4788,6 +4788,7 @@ int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
 	int retries = 0;
 
 	sb_start_pagefault(inode->i_sb);
+	file_update_time(vma->vm_file);
 	/* Delalloc case is easy... */
 	if (test_opt(inode->i_sb, DELALLOC) &&
 	    !ext4_should_journal_data(inode) &&
diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c
index a4d56ac..5b387a4 100644
--- a/fs/nilfs2/file.c
+++ b/fs/nilfs2/file.c
@@ -116,6 +116,7 @@ static int nilfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
 	if (unlikely(ret))
 		goto out;
 
+	file_update_time(vma->vm_file);
 	ret = __block_page_mkwrite(vma, vmf, nilfs_get_block);
 	if (ret) {
 		nilfs_transaction_abort(inode->i_sb);
-- 
1.7.12.rc0.22.gcdd159b


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-01  9:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-30 19:48 [PATCH REGRESSION FIX] ext4: fix mtime update in nodelalloc mode Theodore Ts'o
2012-09-30 19:50 ` Jonathan Nieder
2012-09-30 19:53   ` Theodore Ts'o
     [not found]     ` <20120930195341.GC4780-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2012-09-30 20:30       ` Theodore Ts'o
     [not found]         ` <20120930203026.GD4780-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2012-10-01  9:32           ` Jan Kara
     [not found] ` <1349034499-4731-1-git-send-email-tytso-3s7WtUTddSA@public.gmane.org>
2012-09-30 19:50   ` Theodore Ts'o
2012-09-30 19:51   ` Willy Tarreau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).