From: Behan Webster <behanw@converseincode.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Mark Charlebois <charlebm@gmail.com>,
Behan Webster <behanw@converseincode.com>
Subject: [PATCH] Remove VLAIS usage from JBD2 code
Date: Tue, 30 Oct 2012 14:40:04 -0400 [thread overview]
Message-ID: <1351622404-18214-2-git-send-email-behanw@converseincode.com> (raw)
In-Reply-To: <1351622404-18214-1-git-send-email-behanw@converseincode.com>
From: Mark Charlebois <charlebm@gmail.com>
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
precludes the use of compilers which don't implement VLAIS (for instance the
Clang compiler). Since ctx is always a 32-bit CRC, hard coding a size of 4
bytes accomplishes the same thing without the use of VLAIS. This is the same
technique already employed in fs/ext4/ext4.h
Signed-off-by: Mark Charlebois <charlebm@gmail.com>
Signed-off-by: Behan Webster <behanw@converseincode.com>
---
include/linux/jbd2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 3efc43f..efcbdfc 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -1308,7 +1308,7 @@ static inline u32 jbd2_chksum(journal_t *journal, u32 crc,
{
struct {
struct shash_desc shash;
- char ctx[crypto_shash_descsize(journal->j_chksum_driver)];
+ char ctx[4];
} desc;
int err;
--
1.7.9.5
next prev parent reply other threads:[~2012-10-30 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:40 [PATCH] Removing the use of VLAIS from the Linux Kernel Behan Webster
2012-10-30 18:40 ` Behan Webster [this message]
2012-10-30 19:00 ` [PATCH] Remove VLAIS usage from JBD2 code Theodore Ts'o
2012-10-30 19:02 ` Behan Webster
2012-10-30 19:13 ` Darrick J. Wong
2012-11-08 15:53 ` Theodore Ts'o
2012-11-09 23:19 ` Darrick J. Wong
2012-11-09 23:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351622404-18214-2-git-send-email-behanw@converseincode.com \
--to=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).