linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: gnehzuil.liu@gmail.com, tytso@mit.edu, dmonakhov@openvz.org,
	bergwolf@gmail.com
Subject: [PATCH 0/2 v5] ext4: Fix some fiemap problems
Date: Wed, 21 Nov 2012 23:03:39 +0100	[thread overview]
Message-ID: <1353535421-25631-1-git-send-email-lczerner@redhat.com> (raw)

This patchset fixes mainly two problems in fiemap in ext4. First of all we
could hit BUG_ON() if the extent tree is changed while we are traversing it.
This particular problem has been revealed by xfstest 225 on s390x
architecture.

The other problem is that we potentially might miss some delayed extents
with fiemap if they are written after we've searched the extent tree and
before we're going to search for delayed extent in extent status tree.

Both problems are fixed by the first patch of the patch set. The second
contains just some cleanups.

This has been based on top of the ext4 git tree containing extent status
tree. It has been tested with xfstests on s390x.

Please review carefully since fiemap bugs might cause problems with cp
possibly corrupting user data.

Thanks!
-Lukas

--- 
[PATCH 1/2 v5] ext4: Prevent race while walking extent tree
[PATCH 2/2 v5] ext4: simple cleanup in fiemap codepath

fs/ext4/ext4_extents.h |   14 ----
fs/ext4/extents.c      |  156 ++++++++++++++++++++++++++---------------------
2 files changed, 86 insertions(+), 84 deletions(-)


             reply	other threads:[~2012-11-22 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 22:03 Lukas Czerner [this message]
2012-11-21 22:03 ` [PATCH 1/2 v5] ext4: Prevent race while walking extent tree Lukas Czerner
2012-11-21 22:03 ` [PATCH 2/2 v5] ext4: simple cleanup in fiemap codepath Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353535421-25631-1-git-send-email-lczerner@redhat.com \
    --to=lczerner@redhat.com \
    --cc=bergwolf@gmail.com \
    --cc=dmonakhov@openvz.org \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).