* [PATCH] ext4: remove some unused code lines
@ 2012-11-29 10:00 zwu.kernel
2012-12-02 12:27 ` Zheng Liu
0 siblings, 1 reply; 5+ messages in thread
From: zwu.kernel @ 2012-11-29 10:00 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, linux-kernel, Zhi Yong Wu
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
fs/ext4/extents.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7011ac9..43ec639 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
struct ext4_extent *ex)
{
struct ext4_ext_cache *cex;
- struct ext4_sb_info *sbi;
int ret = 0;
/*
@@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
*/
spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
cex = &EXT4_I(inode)->i_cached_extent;
- sbi = EXT4_SB(inode->i_sb);
/* has cache valid data? */
if (cex->ec_len == 0)
--
1.7.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: remove some unused code lines
2012-11-29 10:00 zwu.kernel
@ 2012-12-02 12:27 ` Zheng Liu
2012-12-03 2:11 ` Zhi Yong Wu
2012-12-07 0:06 ` Theodore Ts'o
0 siblings, 2 replies; 5+ messages in thread
From: Zheng Liu @ 2012-12-02 12:27 UTC (permalink / raw)
To: zwu.kernel; +Cc: linux-ext4, tytso, linux-kernel, Zhi Yong Wu
On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Please write a commit log to describe this patch, even though it is
quite simple and straightfoward
Otherwise, it looks good to me.
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Regards,
- Zheng
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> fs/ext4/extents.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 7011ac9..43ec639 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
> struct ext4_extent *ex)
> {
> struct ext4_ext_cache *cex;
> - struct ext4_sb_info *sbi;
> int ret = 0;
>
> /*
> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
> */
> spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
> cex = &EXT4_I(inode)->i_cached_extent;
> - sbi = EXT4_SB(inode->i_sb);
>
> /* has cache valid data? */
> if (cex->ec_len == 0)
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: remove some unused code lines
2012-12-02 12:27 ` Zheng Liu
@ 2012-12-03 2:11 ` Zhi Yong Wu
2012-12-07 0:06 ` Theodore Ts'o
1 sibling, 0 replies; 5+ messages in thread
From: Zhi Yong Wu @ 2012-12-03 2:11 UTC (permalink / raw)
To: zwu.kernel, linux-ext4, tytso, linux-kernel, Zhi Yong Wu
On Sun, Dec 2, 2012 at 8:27 PM, Zheng Liu <gnehzuil.liu@gmail.com> wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
>> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
Good suggestion, thanks.
>
> Otherwise, it looks good to me.
>
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
>
> Regards,
> - Zheng
>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>> ---
>> fs/ext4/extents.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
>> index 7011ac9..43ec639 100644
>> --- a/fs/ext4/extents.c
>> +++ b/fs/ext4/extents.c
>> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>> struct ext4_extent *ex)
>> {
>> struct ext4_ext_cache *cex;
>> - struct ext4_sb_info *sbi;
>> int ret = 0;
>>
>> /*
>> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
>> */
>> spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
>> cex = &EXT4_I(inode)->i_cached_extent;
>> - sbi = EXT4_SB(inode->i_sb);
>>
>> /* has cache valid data? */
>> if (cex->ec_len == 0)
>> --
>> 1.7.6.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Zhi Yong Wu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ext4: remove some unused code lines
@ 2012-12-03 2:25 zwu.kernel
0 siblings, 0 replies; 5+ messages in thread
From: zwu.kernel @ 2012-12-03 2:25 UTC (permalink / raw)
To: linux-ext4; +Cc: linux-kernel, tytso, Zhi Yong Wu
From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
In ext4_ext_in_cache(), some codes are redundant,
this patch will remove them.
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
fs/ext4/extents.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7011ac9..43ec639 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
struct ext4_extent *ex)
{
struct ext4_ext_cache *cex;
- struct ext4_sb_info *sbi;
int ret = 0;
/*
@@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
*/
spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
cex = &EXT4_I(inode)->i_cached_extent;
- sbi = EXT4_SB(inode->i_sb);
/* has cache valid data? */
if (cex->ec_len == 0)
--
1.7.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ext4: remove some unused code lines
2012-12-02 12:27 ` Zheng Liu
2012-12-03 2:11 ` Zhi Yong Wu
@ 2012-12-07 0:06 ` Theodore Ts'o
1 sibling, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2012-12-07 0:06 UTC (permalink / raw)
To: zwu.kernel, linux-ext4, linux-kernel, Zhi Yong Wu
On Sun, Dec 02, 2012 at 08:27:26PM +0800, Zheng Liu wrote:
> On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
> > From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Please write a commit log to describe this patch, even though it is
> quite simple and straightfoward
>
> Otherwise, it looks good to me.
>
> Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
I've applied this patch with the description:
ext4: remove unused variable from ext4_ext_in_cache()
- Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-07 0:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 2:25 [PATCH] ext4: remove some unused code lines zwu.kernel
-- strict thread matches above, loose matches on Subject: below --
2012-11-29 10:00 zwu.kernel
2012-12-02 12:27 ` Zheng Liu
2012-12-03 2:11 ` Zhi Yong Wu
2012-12-07 0:06 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).