linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: linux-ext4@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH] ext4: Fix the complie warning if CONFIG_EXT4_FS_XATTR isn't set.
Date: Wed,  5 Dec 2012 21:36:23 +0800	[thread overview]
Message-ID: <1354714583-3187-1-git-send-email-tm@tao.ma> (raw)

From: Tao Ma <boyu.mt@taobao.com>

Fix the compile warning created by copy/paste.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/ext4/xattr.h |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
index 39ef0d6..f959e6c 100644
--- a/fs/ext4/xattr.h
+++ b/fs/ext4/xattr.h
@@ -261,9 +261,10 @@ ext4_xattr_ibody_set(handle_t *handle, struct inode *inode,
 	return -EOPNOTSUPP;
 }
 
-extern int ext4_xattr_ibody_get(struct inode *inode, int name_index,
-				const char *name,
-				void *buffer, size_t buffer_size)
+static inline int
+ext4_xattr_ibody_get(struct inode *inode, int name_index,
+		     const char *name,
+		     void *buffer, size_t buffer_size)
 {
 	return -EOPNOTSUPP;
 }
@@ -377,13 +378,15 @@ static inline int ext4_read_inline_dir(struct file *filp,
 	return 0;
 }
 
-struct buffer_head *ext4_find_inline_entry(struct inode *dir,
-					const struct qstr *d_name,
-					struct ext4_dir_entry_2 **res_dir,
-					int *has_inline_data)
+static inline struct buffer_head *
+ext4_find_inline_entry(struct inode *dir,
+		       const struct qstr *d_name,
+		       struct ext4_dir_entry_2 **res_dir,
+		       int *has_inline_data)
 {
 	return NULL;
 }
+
 static inline int ext4_delete_inline_entry(handle_t *handle,
 					   struct inode *dir,
 					   struct ext4_dir_entry_2 *de_del,
@@ -419,7 +422,7 @@ static inline void ext4_inline_data_truncate(struct inode *inode,
 	return;
 }
 
-static int ext4_convert_inline_data(struct inode *inode)
+static inline int ext4_convert_inline_data(struct inode *inode)
 {
 	return 0;
 }
-- 
1.7.1


             reply	other threads:[~2012-12-05 13:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 13:36 Tao Ma [this message]
2012-12-05 16:18 ` [PATCH] ext4: Fix the complie warning if CONFIG_EXT4_FS_XATTR isn't set Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354714583-3187-1-git-send-email-tm@tao.ma \
    --to=tm@tao.ma \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).