From: Darren Hart <dvhart@infradead.org>
To: linux-ext4@vger.kernel.org
Subject: [PATCH RFC 0/3] ext2fsprogs: Symlink support and doc fix
Date: Wed, 5 Dec 2012 13:56:02 -0800 [thread overview]
Message-ID: <1354744565-12594-1-git-send-email-dvhart@infradead.org> (raw)
As we appear to have agreed that adding symlink support to debugfs via a new
ext2fs_symlink() function in libext2fs was something that needed doing, I
thought I'd use this as a trial run for my first contribution to the ext2fsprogs
package before I continue working on the larger project of completing initial
directory support for mke2fs.
While I modeled this patch after existing code, their were some inconcsistencies
in the code examples I used that I'd welcome input on. In particular:
o Should the ext2fs_link() happen right after ext2fs_new_inode()? Or should it
happen closer to the end of the operation? do_write() and ext2fs_mkdir()
handle this differently.
o Is it necessary to allocate the first block and assign it to the inode or the
extents? ext2fs_mkdir() does this, do_write() does not. I opted for the
simpler of the two and it passes my initial simple tests.
o Should I pass "mode" to ext2fs_new_inode() even though it is ignored?
o Would it make sense to try once to expand_dir rather than bailing out of
ext2fs_mkdir() and ext2fs_symlink() if the directory is full?
o What would we like the initial uid,gid,mode,*time values to be for
files/directories/links/etc. created with libext2fs?
Finally, I made an attempt to follow the coding style I observed in the code,
but if I missed something, please let me know.
Thanks,
Darren Hart
Intel Open Source Technology Center
next reply other threads:[~2012-12-05 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 21:56 Darren Hart [this message]
2012-12-05 21:56 ` [PATCH 1/3] lib/ext2fs: Correct interates typo in texinfo docs Darren Hart
2012-12-05 21:56 ` [PATCH 2/3] lib/ext2fs: Add ext2fs_symlink Darren Hart
2012-12-05 21:56 ` [PATCH 3/3] debugfs: Add symlink command Darren Hart
2012-12-10 15:54 ` [PATCH RFC 0/3] ext2fsprogs: Symlink support and doc fix Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354744565-12594-1-git-send-email-dvhart@infradead.org \
--to=dvhart@infradead.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).