* [PATCH] libext2fs: ext2fs_open2() should not set ret_fs after a MMP failure
@ 2013-01-09 2:01 Theodore Ts'o
0 siblings, 0 replies; only message in thread
From: Theodore Ts'o @ 2013-01-09 2:01 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o
The addition of MMP code was added in the wrong place, so ret_fs could
get set (and EXT2_FLAG_NOFREE_ON_ERROR was cleared as well, which
could confuse e2fsck which depends on this flag being cleared if
ext2fs_open2() succeeded.)
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
lib/ext2fs/openfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/ext2fs/openfs.c b/lib/ext2fs/openfs.c
index d483bd9..113b80e 100644
--- a/lib/ext2fs/openfs.c
+++ b/lib/ext2fs/openfs.c
@@ -391,9 +391,6 @@ errcode_t ext2fs_open2(const char *name, const char *io_options,
ext2fs_mark_super_dirty(fs);
}
- fs->flags &= ~EXT2_FLAG_NOFREE_ON_ERROR;
- *ret_fs = fs;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-01-09 2:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09 2:01 [PATCH] libext2fs: ext2fs_open2() should not set ret_fs after a MMP failure Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).