From: Guo Chao <yan@linux.vnet.ibm.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 2/4] ext4: remove unused variable in add_dirent_to_buf()
Date: Fri, 18 Jan 2013 16:01:12 +0800 [thread overview]
Message-ID: <1358496074-6228-2-git-send-email-yan@linux.vnet.ibm.com> (raw)
In-Reply-To: <1358496074-6228-1-git-send-email-yan@linux.vnet.ibm.com>
After commit 978fef9 (create __ext4_insert_dentry for dir entry
insertion), 'reclen' is not used anymore.
Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
---
fs/ext4/namei.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index a445247..b3717a3 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1703,7 +1703,6 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry,
const char *name = dentry->d_name.name;
int namelen = dentry->d_name.len;
unsigned int blocksize = dir->i_sb->s_blocksize;
- unsigned short reclen;
int csum_size = 0;
int err;
@@ -1711,7 +1710,6 @@ static int add_dirent_to_buf(handle_t *handle, struct dentry *dentry,
EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))
csum_size = sizeof(struct ext4_dir_entry_tail);
- reclen = EXT4_DIR_REC_LEN(namelen);
if (!de) {
err = ext4_find_dest_de(dir, inode,
bh, bh->b_data, blocksize - csum_size,
--
1.7.9.5
next prev parent reply other threads:[~2013-01-18 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 8:01 [PATCH 1/4] ext4: release buffer when checksum failed Guo Chao
2013-01-18 8:01 ` Guo Chao [this message]
2013-01-29 1:12 ` [PATCH 2/4] ext4: remove unused variable in add_dirent_to_buf() Darrick J. Wong
2013-01-29 2:28 ` Theodore Ts'o
2013-01-18 8:01 ` [PATCH 3/4] ext4: remove useless assignment in dx_probe() Guo Chao
2013-01-29 1:21 ` Darrick J. Wong
2013-01-29 2:37 ` Theodore Ts'o
2013-01-29 2:35 ` Theodore Ts'o
2013-01-18 8:01 ` [PATCH 4/4] ext4: remove unnecessary NULL pointer check Guo Chao
2013-01-29 1:24 ` Darrick J. Wong
2013-01-29 2:40 ` Guo Chao
2013-01-29 2:42 ` Theodore Ts'o
2013-01-18 21:28 ` [PATCH 1/4] ext4: release buffer when checksum failed Darrick J. Wong
2013-01-29 2:25 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358496074-6228-2-git-send-email-yan@linux.vnet.ibm.com \
--to=yan@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).