linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>, stable@vger.kernel.org
Subject: [PATCH 1/2] ext4: release sysfs kobject when failing to enable quotas on mount
Date: Mon, 21 Jan 2013 01:46:20 -0500	[thread overview]
Message-ID: <1358750781-5670-1-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <20130121054741.GB321@thunk.org>

In addition, print the error returned from ext4_enable_quotas()

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
---
 fs/ext4/super.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 30651bd..0a6e9d5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4015,7 +4015,7 @@ no_journal:
 	    !(sb->s_flags & MS_RDONLY)) {
 		err = ext4_enable_quotas(sb);
 		if (err)
-			goto failed_mount7;
+			goto failed_mount8;
 	}
 #endif  /* CONFIG_QUOTA */
 
@@ -4042,6 +4042,8 @@ cantfind_ext4:
 		ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
 	goto failed_mount;
 
+failed_mount8:
+	kobject_del(&sbi->s_kobj);
 failed_mount7:
 	ext4_unregister_li_request(sb);
 failed_mount6:
@@ -5012,9 +5014,9 @@ static int ext4_enable_quotas(struct super_block *sb)
 						DQUOT_USAGE_ENABLED);
 			if (err) {
 				ext4_warning(sb,
-					"Failed to enable quota (type=%d) "
-					"tracking. Please run e2fsck to fix.",
-					type);
+					"Failed to enable quota tracking "
+					"(type=%d, err=%d). Please run "
+					"e2fsck to fix.", type, err);
 				return err;
 			}
 		}
-- 
1.7.12.rc0.22.gcdd159b

  reply	other threads:[~2013-01-21  6:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-19  2:40 how to quotacheck with the new quota implementation (hidden inode)? Carlos Carvalho
2013-01-21  5:47 ` Theodore Ts'o
2013-01-21  6:46   ` Theodore Ts'o [this message]
2013-01-21  6:46     ` [PATCH 2/2] quota: autoload the quota_v2 module for QFMT_VFS_V1 quota format Theodore Ts'o
2013-01-21 10:40       ` Jan Kara
2013-01-21 15:01         ` Theodore Ts'o
2013-01-21 15:10           ` Jan Kara
2013-01-21 15:50             ` Theodore Ts'o
2013-01-21 19:08               ` Jan Kara
2013-01-21 12:16       ` Carlos Maiolino
2013-01-21 12:12     ` [PATCH 1/2] ext4: release sysfs kobject when failing to enable quotas on mount Carlos Maiolino
2013-01-21 17:26   ` how to quotacheck with the new quota implementation (hidden inode)? Carlos Carvalho
2013-01-21 19:34   ` Aditya Kali
2013-01-31 19:01   ` Carlos Carvalho
2013-01-31 19:04     ` Aditya Kali
2013-01-31 19:13       ` Carlos Carvalho
2013-01-31 22:03         ` Theodore Ts'o
2013-01-31 22:28           ` Jan Kara
2013-01-31 22:44             ` Carlos Carvalho
2013-01-31 23:03             ` Theodore Ts'o
2013-02-04  9:42               ` Jan Kara
2013-01-31 22:41           ` Carlos Carvalho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358750781-5670-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).