* [PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check
@ 2013-02-12 18:23 Tim Gardner
2013-02-14 16:15 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Tim Gardner @ 2013-02-12 18:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Tim Gardner, Andrew Morton, Jan Kara, linux-ext4
smatch analysis:
fs/jbd/transaction.c:236 start_this_handle() info: redundant null
check on new_transaction calling kfree()
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
fs/jbd/transaction.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 071d690..ee40b4e 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -232,8 +232,7 @@ repeat_locked:
lock_map_acquire(&handle->h_lockdep_map);
out:
- if (unlikely(new_transaction)) /* It's usually NULL */
- kfree(new_transaction);
+ kfree(new_transaction);
return ret;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check
2013-02-12 18:23 [PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check Tim Gardner
@ 2013-02-14 16:15 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-02-14 16:15 UTC (permalink / raw)
To: Tim Gardner; +Cc: linux-kernel, Andrew Morton, Jan Kara, linux-ext4
On Tue 12-02-13 11:23:24, Tim Gardner wrote:
> smatch analysis:
>
> fs/jbd/transaction.c:236 start_this_handle() info: redundant null
> check on new_transaction calling kfree()
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: linux-ext4@vger.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
> fs/jbd/transaction.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 071d690..ee40b4e 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -232,8 +232,7 @@ repeat_locked:
>
> lock_map_acquire(&handle->h_lockdep_map);
> out:
> - if (unlikely(new_transaction)) /* It's usually NULL */
> - kfree(new_transaction);
> + kfree(new_transaction);
> return ret;
Thanks for the patch but I actually think this is deliberate because
new_transaction is usually NULL while kfree() is optimized for passed
pointer to be usually != NULL. Also we save a function call in the common
case. So I'm for the code to stay as is.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-14 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 18:23 [PATCH linux-next] jbd: start_this_handle(): remove kfree() redundant null check Tim Gardner
2013-02-14 16:15 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).