From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: [PATCH 2/4] libext2fs: Fix return value in ext2fs_test_block_bitmap_range2()
Date: Mon, 25 Feb 2013 16:55:06 +0100 [thread overview]
Message-ID: <1361807708-15871-3-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1361807708-15871-1-git-send-email-jack@suse.cz>
We used return without a return value in
ext2fs_test_block_bitmap_range2() despite the fuction returns int.
Signed-off-by: Jan Kara <jack@suse.cz>
---
lib/ext2fs/gen_bitmap64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/ext2fs/gen_bitmap64.c b/lib/ext2fs/gen_bitmap64.c
index 42a97d4..44ac499 100644
--- a/lib/ext2fs/gen_bitmap64.c
+++ b/lib/ext2fs/gen_bitmap64.c
@@ -658,7 +658,7 @@ int ext2fs_test_block_bitmap_range2(ext2fs_block_bitmap bmap,
if ((block < bmap->start) || (block+num-1 > bmap->end)) {
ext2fs_warn_bitmap(EXT2_ET_BAD_BLOCK_TEST, block,
bmap->description);
- return;
+ return EINVAL;
}
return bmap->bitmap_ops->test_clear_bmap_extent(bmap, block, num);
--
1.7.1
next prev parent reply other threads:[~2013-02-25 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 15:55 [PATCH 0/4] Compilation fixes for e2fsprogs Jan Kara
2013-02-25 15:55 ` [PATCH 1/4] e2p: Fix 's' handling in parse_num_blocks2() Jan Kara
2013-03-01 1:13 ` [1/4] " Theodore Ts'o
2013-02-25 15:55 ` Jan Kara [this message]
2013-03-01 1:06 ` [2/4] libext2fs: Fix return value in ext2fs_test_block_bitmap_range2() Theodore Ts'o
2013-02-25 15:55 ` [PATCH 3/4] libext2fs: Provide prototype for ext2fs_symlink() Jan Kara
2013-03-01 1:13 ` [3/4] " Theodore Ts'o
2013-02-25 15:55 ` [PATCH 4/4] resize: bigalloc_check() should have return type void Jan Kara
2013-03-01 1:07 ` [4/4] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361807708-15871-3-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).