From: Theodore Ts'o <tytso@mit.edu>
To: xfs@oss.sgi.com
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] xfstests: don't assume that falloc_punch implies falloc in test 255
Date: Tue, 5 Mar 2013 12:59:42 -0500 [thread overview]
Message-ID: <1362506382-26974-1-git-send-email-tytso@mit.edu> (raw)
As of Linux 3.9-rc1, ext4 will support the punch operation on file
systems using indirect blocks, but it can not support the fallocate
operation (since there is no way to mark a block as uninitialized
using indirect block scheme). This caused test 255 to fail, since it
only used _require_xfS_io_falloc_punch assuming that all file systems
which supported punch can also support fallocate. Fix this.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
255 | 1 +
1 file changed, 1 insertion(+)
diff --git a/255 b/255
index 0083963..ae1d8e0 100755
--- a/255
+++ b/255
@@ -48,6 +48,7 @@ _supported_fs generic
_supported_os Linux
_require_xfs_io_falloc_punch
+_require_xfs_io_falloc
_require_xfs_io_fiemap
testfile=$TEST_DIR/255.$$
--
1.7.12.rc0.22.gcdd159b
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-03-05 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 17:59 Theodore Ts'o [this message]
2013-03-05 18:51 ` [PATCH] xfstests: don't assume that falloc_punch implies falloc in test 255 Rich Johnston
2013-03-05 19:07 ` Rich Johnston
2013-03-06 16:10 ` Eric Sandeen
2013-03-06 16:52 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362506382-26974-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).