From: Dmitry Monakhov <dmonakhov@openvz.org>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, wenqing.lz@taobao.com,
Dmitry Monakhov <dmonakhov@openvz.org>
Subject: [PATCH 1/2] ext4: fix usless declarations
Date: Wed, 3 Apr 2013 14:58:30 +0400 [thread overview]
Message-ID: <1364986711-3630-1-git-send-email-dmonakhov@openvz.org> (raw)
This patch should fix sparse complains about shadow declatations.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
fs/ext4/ialloc.c | 1 -
fs/ext4/ioctl.c | 1 -
fs/ext4/mballoc.c | 1 -
fs/ext4/move_extent.c | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 6c5bb8d..4c358f7 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -899,7 +899,6 @@ got:
if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)) {
__u32 csum;
- struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
__le32 inum = cpu_to_le32(inode->i_ino);
__le32 gen = cpu_to_le32(inode->i_generation);
csum = ext4_chksum(sbi, sbi->s_csum_seed, (__u8 *)&inum,
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index a07b7bc..fb4e77f 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -355,7 +355,6 @@ group_add_out:
case EXT4_IOC_RESIZE_FS: {
ext4_fsblk_t n_blocks_count;
- struct super_block *sb = inode->i_sb;
int err = 0, err2 = 0;
ext4_group_t o_group = EXT4_SB(sb)->s_groups_count;
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 580aada..5bf8056 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -860,7 +860,6 @@ static int ext4_mb_init_cache(struct page *page, char *incore)
first_block = page->index * blocks_per_page;
for (i = 0; i < blocks_per_page; i++) {
- int group;
group = (first_block + i) >> 1;
if (group >= ngroups)
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 33e1c08..7f3ed63 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -856,7 +856,6 @@ mext_page_mkuptodate(struct page *page, unsigned from, unsigned to)
if (buffer_uptodate(bh))
continue;
if (!buffer_mapped(bh)) {
- int err = 0;
err = ext4_get_block(inode, block, bh, 0);
if (err) {
SetPageError(page);
--
1.7.1
next reply other threads:[~2013-04-03 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 10:58 Dmitry Monakhov [this message]
2013-04-03 10:58 ` [PATCH 2/2] ext4: fix cpu_vs_disk conversions Dmitry Monakhov
2013-04-03 12:33 ` Theodore Ts'o
2013-04-03 12:58 ` Dmitry Monakhov
2013-04-03 13:04 ` Zheng Liu
2013-04-03 16:01 ` Theodore Ts'o
2013-04-03 15:37 ` Theodore Ts'o
2013-04-03 15:55 ` Dmitry Monakhov
2013-04-04 14:42 ` Dmitry Monakhov
2013-04-10 4:01 ` Theodore Ts'o
2013-04-10 4:02 ` [PATCH 1/3] ext4: fix big-endian bug in extent migration code Theodore Ts'o
2013-04-10 4:02 ` [PATCH 2/3] ext4: fix big-endian bug in metadata checksum calculations Theodore Ts'o
2013-04-10 4:02 ` [PATCH 3/3] ext4: fix miscellaneous big endian warnings Theodore Ts'o
2013-04-03 12:26 ` [PATCH 1/2] ext4: fix usless declarations Theodore Ts'o
2013-04-03 12:31 ` Dmitry Monakhov
2013-04-10 2:50 ` [1/2] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364986711-3630-1-git-send-email-dmonakhov@openvz.org \
--to=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).