linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: gnehzuil.liu@gmail.com, Lukas Czerner <lczerner@redhat.com>
Subject: [PATCH 2/2 v2] ext4: Do not convert to indirect with bigalloc enabled
Date: Tue,  9 Apr 2013 13:24:47 +0200	[thread overview]
Message-ID: <1365506687-9216-2-git-send-email-lczerner@redhat.com> (raw)
In-Reply-To: <1365506687-9216-1-git-send-email-lczerner@redhat.com>

With bigalloc feature enabled we do not support indirect addressing at all
so we have to prevent extent addressing to indirect addressing
conversion in this case. The problem has been introduced with the commit
"ext4: support simple conversion of extent-mapped inodes to use i_blocks"

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
v2: added to the series

 fs/ext4/migrate.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index 3464604..f13a289 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -625,6 +625,10 @@ int ext4_ind_migrate(struct inode *inode)
 	    (!ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
 		return -EINVAL;
 
+	if (EXT4_HAS_RO_COMPAT_FEATURE(inode->i_sb,
+				       EXT4_FEATURE_RO_COMPAT_BIGALLOC))
+		return -EOPNOTSUPP;
+
 	down_write(&EXT4_I(inode)->i_data_sem);
 	ret = ext4_ext_check_inode(inode);
 	if (ret)
-- 
1.7.7.6


  reply	other threads:[~2013-04-09 11:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 11:24 [PATCH 1/2 v2] ext4: move ext4_ind_migrate() into migrate.c Lukas Czerner
2013-04-09 11:24 ` Lukas Czerner [this message]
2013-04-09 12:48   ` [PATCH 2/2 v2] ext4: Do not convert to indirect with bigalloc enabled Zheng Liu
2013-04-11  3:58   ` Theodore Ts'o
2013-04-09 12:47 ` [PATCH 1/2 v2] ext4: move ext4_ind_migrate() into migrate.c Zheng Liu
2013-04-11  3:58 ` Theodore Ts'o
2013-04-11  5:54   ` Dmitry Monakhov
2013-04-11  8:18   ` Lukáš Czerner
2013-04-11 14:56     ` Theodore Ts'o
2013-04-11 15:15       ` Lukáš Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365506687-9216-2-git-send-email-lczerner@redhat.com \
    --to=lczerner@redhat.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).