linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: linux-mm@kvack.org,
	Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
	mgorman@suse.de, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH 2/3] buffer: add BH_Prio and BH_Meta flags
Date: Sat, 20 Apr 2013 20:07:07 -0400	[thread overview]
Message-ID: <1366502828-7793-2-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1366502828-7793-1-git-send-email-tytso@mit.edu>

Add buffer_head flags so that buffer cache writebacks can be marked
with the the appropriate request flags, so that metadata blocks can be
marked appropriately in blktrace.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/buffer.c                 | 5 +++++
 include/linux/buffer_head.h | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index b4dcb34..a15575c 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2988,6 +2988,11 @@ int submit_bh(int rw, struct buffer_head * bh)
 	/* Take care of bh's that straddle the end of the device */
 	guard_bh_eod(rw, bio, bh);
 
+	if (buffer_meta(bh))
+		rw |= REQ_META;
+	if (buffer_prio(bh))
+		rw |= REQ_PRIO;
+
 	bio_get(bio);
 	submit_bio(rw, bio);
 
diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
index 5afc4f9..33c0f81 100644
--- a/include/linux/buffer_head.h
+++ b/include/linux/buffer_head.h
@@ -34,6 +34,8 @@ enum bh_state_bits {
 	BH_Write_EIO,	/* I/O error on write */
 	BH_Unwritten,	/* Buffer is allocated on disk but not written */
 	BH_Quiet,	/* Buffer Error Prinks to be quiet */
+	BH_Meta,	/* Buffer contains metadata */
+	BH_Prio,	/* Buffer should be submitted with REQ_PRIO */
 
 	BH_PrivateStart,/* not a state bit, but the first bit available
 			 * for private allocation by other entities
@@ -124,6 +126,8 @@ BUFFER_FNS(Delay, delay)
 BUFFER_FNS(Boundary, boundary)
 BUFFER_FNS(Write_EIO, write_io_error)
 BUFFER_FNS(Unwritten, unwritten)
+BUFFER_FNS(Meta, meta)
+BUFFER_FNS(Prio, prio)
 
 #define bh_offset(bh)		((unsigned long)(bh)->b_data & ~PAGE_MASK)
 
-- 
1.7.12.rc0.22.gcdd159b

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-04-21  0:07 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 14:27 Excessive stall times on ext4 in 3.9-rc2 Mel Gorman
2013-04-02 15:00 ` Jiri Slaby
2013-04-02 15:03 ` Zheng Liu
2013-04-02 15:15   ` Mel Gorman
2013-04-02 15:06 ` Theodore Ts'o
2013-04-02 15:14   ` Theodore Ts'o
2013-04-02 18:19     ` Theodore Ts'o
2013-04-07 21:59       ` Frank Ch. Eigler
2013-04-08  8:36         ` Mel Gorman
2013-04-08 10:52           ` Frank Ch. Eigler
2013-04-08 11:01         ` Theodore Ts'o
2013-04-03 10:19     ` Mel Gorman
2013-04-03 12:05       ` Theodore Ts'o
2013-04-03 15:15         ` Mel Gorman
2013-04-05 22:18       ` Jiri Slaby
2013-04-05 23:16         ` Theodore Ts'o
2013-04-06  7:29           ` Jiri Slaby
2013-04-06  7:37             ` Jiri Slaby
2013-04-06  8:19               ` Jiri Slaby
2013-04-06 13:15             ` Theodore Ts'o
2013-04-10 10:56   ` Mel Gorman
2013-04-10 13:12     ` Theodore Ts'o
2013-04-11 17:04       ` Mel Gorman
2013-04-11 18:35         ` Theodore Ts'o
2013-04-11 21:33           ` Jan Kara
2013-04-12  2:57             ` Theodore Ts'o
2013-04-12  4:50               ` Dave Chinner
2013-04-12 15:19                 ` Theodore Ts'o
2013-04-13  1:23                   ` Dave Chinner
2013-04-22 14:38                   ` Mel Gorman
2013-04-22 22:42                     ` Jeff Moyer
2013-04-23  0:02                       ` Theodore Ts'o
2013-04-23  9:31                       ` Jan Kara
2013-04-23 14:01                       ` Mel Gorman
2013-04-24 19:09                         ` Jeff Moyer
2013-04-25 12:21                           ` Mel Gorman
2013-04-12  9:47               ` Mel Gorman
2013-04-21  0:05                 ` Theodore Ts'o
2013-04-21  0:07                   ` [PATCH 1/3] ext4: mark all metadata I/O with REQ_META Theodore Ts'o
2013-04-21  0:07                     ` Theodore Ts'o [this message]
2013-04-21  0:07                     ` [PATCH 3/3] ext4: mark metadata blocks using bh flags Theodore Ts'o
2013-04-21  6:09                       ` Jiri Slaby
2013-04-21 19:55                         ` Theodore Ts'o
2013-04-21 20:48                           ` [PATCH 3/3 -v2] " Theodore Ts'o
2013-04-22 12:06                     ` [PATCH 1/3] ext4: mark all metadata I/O with REQ_META Zheng Liu
2013-04-23 15:33                   ` Excessive stall times on ext4 in 3.9-rc2 Mel Gorman
2013-04-23 15:50                     ` Theodore Ts'o
2013-04-23 16:13                       ` Mel Gorman
2013-04-12 10:18               ` Tvrtko Ursulin
2013-04-12  9:45           ` Mel Gorman
2013-04-02 23:16 ` Theodore Ts'o
2013-04-03 15:22   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366502828-7793-2-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).