* [PATCH] ext4: add check for inodes_count overflow in new resize ioctl
@ 2013-04-22 2:57 Theodore Ts'o
2013-04-22 14:55 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2013-04-22 2:57 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o, stable
Addresses-Red-Hat-Bugzilla: #913245
Reported-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
---
fs/ext4/resize.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 08d2312..b27c96d 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1882,6 +1882,10 @@ retry:
return 0;
n_group = ext4_get_group_number(sb, n_blocks_count - 1);
+ if (n_group > (0xFFFFFFFFUL / EXT4_INODES_PER_GROUP(sb))) {
+ ext4_warning(sb, "resize would cause inodes_count overflow");
+ return -EINVAL;
+ }
ext4_get_group_no_and_offset(sb, o_blocks_count - 1, &o_group, &offset);
n_desc_blocks = num_desc_blocks(sb, n_group + 1);
--
1.7.12.rc0.22.gcdd159b
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ext4: add check for inodes_count overflow in new resize ioctl
2013-04-22 2:57 [PATCH] ext4: add check for inodes_count overflow in new resize ioctl Theodore Ts'o
@ 2013-04-22 14:55 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2013-04-22 14:55 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, stable
Looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
On Sun, Apr 21, 2013 at 10:57:05PM -0400, Theodore Ts'o wrote:
> Addresses-Red-Hat-Bugzilla: #913245
>
> Reported-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: stable@vger.kernel.org
> ---
> fs/ext4/resize.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
> index 08d2312..b27c96d 100644
> --- a/fs/ext4/resize.c
> +++ b/fs/ext4/resize.c
> @@ -1882,6 +1882,10 @@ retry:
> return 0;
>
> n_group = ext4_get_group_number(sb, n_blocks_count - 1);
> + if (n_group > (0xFFFFFFFFUL / EXT4_INODES_PER_GROUP(sb))) {
> + ext4_warning(sb, "resize would cause inodes_count overflow");
> + return -EINVAL;
> + }
> ext4_get_group_no_and_offset(sb, o_blocks_count - 1, &o_group, &offset);
>
> n_desc_blocks = num_desc_blocks(sb, n_group + 1);
> --
> 1.7.12.rc0.22.gcdd159b
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-22 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-22 2:57 [PATCH] ext4: add check for inodes_count overflow in new resize ioctl Theodore Ts'o
2013-04-22 14:55 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).