From: Ashish Sangwan <ashishsangwan2@gmail.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, wenqing.lz@taobao.com,
Ashish Sangwan <a.sangwan@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>
Subject: [PATCH] ext4: remove unneeded call to ext4_es_remove_extent in punch hole
Date: Sat, 27 Apr 2013 10:00:53 +0530 [thread overview]
Message-ID: <1367037053-1893-1-git-send-email-ashish.sangwan2@gmail.com> (raw)
From: Ashish Sangwan <a.sangwan@samsung.com>
During punch hole, before removing extents we make sure that the blocks
are commited to disk by calling filemap_write_and_wait_range. So, the
extents cannot be present on extent status tree.
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
fs/ext4/inode.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 50cced9..944eb15 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3749,13 +3749,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)
down_write(&EXT4_I(inode)->i_data_sem);
ext4_discard_preallocations(inode);
- ret = ext4_es_remove_extent(inode, first_block,
- stop_block - first_block);
- if (ret) {
- up_write(&EXT4_I(inode)->i_data_sem);
- goto out_stop;
- }
next reply other threads:[~2013-04-27 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 4:30 Ashish Sangwan [this message]
2013-04-27 5:28 ` [PATCH] ext4: remove unneeded call to ext4_es_remove_extent in punch hole Zheng Liu
2013-04-27 6:50 ` Ashish Sangwan
2013-04-27 7:11 ` Zheng Liu
2013-04-29 8:40 ` Ashish Sangwan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367037053-1893-1-git-send-email-ashish.sangwan2@gmail.com \
--to=ashishsangwan2@gmail.com \
--cc=a.sangwan@samsung.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).