From: Jan Kara <jack@suse.cz>
To: xfs@oss.sgi.com
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: [PATCH 2/3] 285: Fix file syncing
Date: Thu, 30 May 2013 14:45:38 +0200 [thread overview]
Message-ID: <1369917939-22660-2-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1369917939-22660-1-git-send-email-jack@suse.cz>
The intention of tests 08 and 09 in test generic/285 is to sync the
whole file before checking for data and holes. However the helper is
called with nbytes argument set to 0 which results in not syncing
anything. Set nbytes properly.
Signed-off-by: Jan Kara <jack@suse.cz>
---
src/seek_sanity_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index eec6903..7d5868b 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -229,7 +229,7 @@ static int test09(int fd, int testnum)
* Sync out dirty pages from bufsz * 100, this will convert
* the dirty page to writeback.
*/
- ret = do_sync_dirty_pages(fd, bufsz * 100, 0);
+ ret = do_sync_dirty_pages(fd, bufsz * 100, filsz);
if (ret)
goto out;
@@ -269,7 +269,7 @@ static int test08(int fd, int testnum)
goto out;
/* Sync out all file */
- ret = do_sync_dirty_pages(fd, 0, 0);
+ ret = do_sync_dirty_pages(fd, 0, filsz);
if (ret)
goto out;
--
1.8.1.4
next prev parent reply other threads:[~2013-05-30 12:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 12:45 [PATCH 1/3] 285: Fix test for ext4 in some configurations Jan Kara
2013-05-30 12:45 ` Jan Kara [this message]
2013-05-30 13:47 ` [PATCH 2/3] 285: Fix file syncing Eric Sandeen
2013-05-30 19:57 ` Jan Kara
2013-05-30 12:45 ` [PATCH 3/3] 285: Test offsets over 4GB Jan Kara
2013-05-30 13:48 ` Eric Sandeen
2013-05-30 20:01 ` Jan Kara
2013-05-30 20:05 ` Eric Sandeen
2013-05-30 20:49 ` Jan Kara
2013-05-30 22:34 ` Dave Chinner
2013-05-31 8:22 ` Jan Kara
2013-05-30 13:45 ` [PATCH 1/3] 285: Fix test for ext4 in some configurations Eric Sandeen
2013-05-30 22:30 ` Dave Chinner
2013-05-31 8:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369917939-22660-2-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).