* [PATCH] ext4: don't show usrquota/grpquota twice in /proc/mounts
@ 2013-07-11 22:55 Theodore Ts'o
2013-07-16 15:18 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2013-07-11 22:55 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o, stable
We now print mount options in a generic fashion in
ext4_show_options(), so we shouldn't be explicitly printing the
{usr,grp}quota options in ext4_show_quota_options().
Without this patch, /proc/mounts can look like this:
/dev/vdb /vdb ext4 rw,relatime,quota,usrquota,data=ordered,usrquota 0 0
^^^^^^^^ ^^^^^^^^
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
---
fs/ext4/super.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 8862d4d..bca26f3 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1702,12 +1702,6 @@ static inline void ext4_show_quota_options(struct seq_file *seq,
if (sbi->s_qf_names[GRPQUOTA])
seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]);
-
- if (test_opt(sb, USRQUOTA))
- seq_puts(seq, ",usrquota");
-
- if (test_opt(sb, GRPQUOTA))
- seq_puts(seq, ",grpquota");
#endif
}
--
1.7.12.rc0.22.gcdd159b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: don't show usrquota/grpquota twice in /proc/mounts
2013-07-11 22:55 [PATCH] ext4: don't show usrquota/grpquota twice in /proc/mounts Theodore Ts'o
@ 2013-07-16 15:18 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-07-16 15:18 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, stable
On Thu 11-07-13 18:55:05, Ted Tso wrote:
> We now print mount options in a generic fashion in
> ext4_show_options(), so we shouldn't be explicitly printing the
> {usr,grp}quota options in ext4_show_quota_options().
>
> Without this patch, /proc/mounts can look like this:
>
> /dev/vdb /vdb ext4 rw,relatime,quota,usrquota,data=ordered,usrquota 0 0
> ^^^^^^^^ ^^^^^^^^
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: stable@vger.kernel.org
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 8862d4d..bca26f3 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1702,12 +1702,6 @@ static inline void ext4_show_quota_options(struct seq_file *seq,
>
> if (sbi->s_qf_names[GRPQUOTA])
> seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]);
> -
> - if (test_opt(sb, USRQUOTA))
> - seq_puts(seq, ",usrquota");
> -
> - if (test_opt(sb, GRPQUOTA))
> - seq_puts(seq, ",grpquota");
> #endif
> }
>
> --
> 1.7.12.rc0.22.gcdd159b
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-16 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11 22:55 [PATCH] ext4: don't show usrquota/grpquota twice in /proc/mounts Theodore Ts'o
2013-07-16 15:18 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).