From: Robert Yang <liezhi.yang@windriver.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <dvhart@linux.intel.com>, <darrick.wong@oracle.com>
Subject: [PATCH 0/2 V3] e2fsprogs/debugfs: do sparse copy when src is a sparse file
Date: Mon, 29 Jul 2013 17:06:23 +0800 [thread overview]
Message-ID: <1375088785-30653-1-git-send-email-liezhi.yang@windriver.com> (raw)
=== V3:
* Use BUFSIZ (which is 8192 on Linux systems) for the max argument
length as Ted suggested.
* Use ext2fs_get_memzero() and move it out of the while loop to get a
better performance as Darrick suggested.
=== V2:
* Use 64K for the IO_BUFSIZE and use malloc() to allocate the memory for
the buffer respect to Darrick's comments.
* Use calloc() and memcmp() to check the sparse block as Darrick
suggested.
* Adjust the frame and remove a few un-needed code as Darrick
suggested.
=== V1:
* There are two patches, one is used for fixing the max length of the
argument, the other one is for sparsing copy when src is a sparse
file.
* BTW., we are trying to use the debugfs to create an ext2/ext3/ext4
image based on a given directory or file, which is similar to genext2fs,
please vist here for the script you are interested in it:
https://gist.github.com/robertlinux/6034499
It is an external shell script at the moment, the performance is not good,
so we are going to:
- Integrate this function into mke2fs in C language.
- Add a [-d <directory>] option to specify the initial directory in mke2fs
I'm not sure whether such a patch is acceptable or not, please feel free to
give your comments.
Robert Yang
Wind River System
Robert Yang (2):
debugfs.c: the max length of debugfs argument is too short
debugfs.c: do sparse copy when src is a sparse file
debugfs/debugfs.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 62 insertions(+), 5 deletions(-)
--
1.8.1.2
next reply other threads:[~2013-07-29 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 9:06 Robert Yang [this message]
2013-07-29 9:06 ` [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short Robert Yang
2013-07-29 9:06 ` [PATCH 2/2] debugfs.c: do sparse copy when src is a sparse file Robert Yang
2013-08-19 22:43 ` Darren Hart
2013-08-06 1:46 ` [PATCH 0/2 V3] e2fsprogs/debugfs: " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375088785-30653-1-git-send-email-liezhi.yang@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).