From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: linux-ext4@vger.kernel.org
Cc: jack@suse.cz, tytso@mit.edu, lkp@linux.intel.com, "Yan,
Zheng" <zheng.z.yan@intel.com>
Subject: [PATCH] ext4: fix dirty pages writback regression.
Date: Tue, 10 Sep 2013 10:02:58 +0800 [thread overview]
Message-ID: <1378778578-5000-1-git-send-email-zheng.z.yan@intel.com> (raw)
From: "Yan, Zheng" <zheng.z.yan@intel.com>
Our Linux Kernel Performance project found that commit 4e7ea81db5
(ext4: restructure writeback path) indroduced regression. After
the commit, ext4 does not merge adjacent mapped dirty pages during
writeback. The "!buffer_delay(bh) && !buffer_unwritten(bh)" check
in mpage_add_bh_to_extent() prevents the merging.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
---
fs/ext4/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index c79fd7d..bfeb8b2 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1944,8 +1944,7 @@ static bool mpage_add_bh_to_extent(struct mpage_da_data *mpd, ext4_lblk_t lblk,
struct ext4_map_blocks *map = &mpd->map;
/* Buffer that doesn't need mapping for writeback? */
- if (!buffer_dirty(bh) || !buffer_mapped(bh) ||
- (!buffer_delay(bh) && !buffer_unwritten(bh))) {
+ if (!buffer_dirty(bh) || !buffer_mapped(bh)) {
/* So far no extent to map => we write the buffer right away */
if (map->m_len == 0)
return true;
--
1.8.1.4
next reply other threads:[~2013-09-10 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 2:02 Yan, Zheng [this message]
2013-09-10 9:00 ` [PATCH] ext4: fix dirty pages writback regression Jan Kara
2013-09-10 9:10 ` Yan, Zheng
2013-09-10 9:17 ` Jan Kara
2013-09-10 11:01 ` Yan, Zheng
2013-09-10 11:15 ` Jan Kara
2013-09-10 12:53 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378778578-5000-1-git-send-email-zheng.z.yan@intel.com \
--to=zheng.z.yan@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=lkp@linux.intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox