* [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
@ 2013-09-18 20:17 Azat Khuzhin
2013-10-30 14:55 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Azat Khuzhin @ 2013-09-18 20:17 UTC (permalink / raw)
To: linux-kernel
Cc: Azat Khuzhin, Theodore Ts'o, Andreas Dilger,
open list:EXT4 FILE SYSTEM
Functions that need in it, already calculate reclen from namelen by
themselves:
- ext4_find_dest_de()
- ext4_insert_dentry()
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
---
fs/ext4/inline.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index d9ecbf1..809f285 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -994,11 +994,9 @@ static int ext4_add_dirent_to_inline(handle_t *handle,
struct inode *dir = dentry->d_parent->d_inode;
const char *name = dentry->d_name.name;
int namelen = dentry->d_name.len;
- unsigned short reclen;
int err;
struct ext4_dir_entry_2 *de;
- reclen = EXT4_DIR_REC_LEN(namelen);
err = ext4_find_dest_de(dir, inode, iloc->bh,
inline_start, inline_size,
name, namelen, &de);
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
2013-09-18 20:17 [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline() Azat Khuzhin
@ 2013-10-30 14:55 ` Theodore Ts'o
2013-10-30 17:02 ` Azat Khuzhin
0 siblings, 1 reply; 4+ messages in thread
From: Theodore Ts'o @ 2013-10-30 14:55 UTC (permalink / raw)
To: Azat Khuzhin; +Cc: linux-kernel, Andreas Dilger, open list:EXT4 FILE SYSTEM
On Thu, Sep 19, 2013 at 12:17:30AM +0400, Azat Khuzhin wrote:
> Functions that need in it, already calculate reclen from namelen by
> themselves:
> - ext4_find_dest_de()
> - ext4_insert_dentry()
>
> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
2013-10-30 14:55 ` Theodore Ts'o
@ 2013-10-30 17:02 ` Azat Khuzhin
2013-10-30 18:29 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Azat Khuzhin @ 2013-10-30 17:02 UTC (permalink / raw)
To: Theodore Ts'o, Azat Khuzhin, open list, Andreas Dilger,
open list:EXT4 FILE SYSTEM
On Wed, Oct 30, 2013 at 6:55 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Thu, Sep 19, 2013 at 12:17:30AM +0400, Azat Khuzhin wrote:
>> Functions that need in it, already calculate reclen from namelen by
>> themselves:
>> - ext4_find_dest_de()
>> - ext4_insert_dentry()
>>
>> Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
>
> Applied, thanks.
Thank you!
But there is a typo in subject, s/unsed/unused/ could you fix or it,
or tell me, and I will resend it?
Thanks!
>
> - Ted
--
Respectfully
Azat Khuzhin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline()
2013-10-30 17:02 ` Azat Khuzhin
@ 2013-10-30 18:29 ` Theodore Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2013-10-30 18:29 UTC (permalink / raw)
To: Azat Khuzhin; +Cc: open list, Andreas Dilger, open list:EXT4 FILE SYSTEM
On Wed, Oct 30, 2013 at 09:02:35PM +0400, Azat Khuzhin wrote:
>
> Thank you!
> But there is a typo in subject, s/unsed/unused/ could you fix or it,
> or tell me, and I will resend it?
I had already reworeded the commit description as follows:
ext4: drop set but otherwise unused variable from ext4_add_dirent_to_inline()
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cheers,
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-30 18:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 20:17 [PATCH] ext4: drop unsed reclen variable from ext4_add_dirent_to_inline() Azat Khuzhin
2013-10-30 14:55 ` Theodore Ts'o
2013-10-30 17:02 ` Azat Khuzhin
2013-10-30 18:29 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).