* [PATCH] tests: delete temporary resize test files
@ 2013-12-17 6:26 Andreas Dilger
2013-12-23 21:02 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Dilger @ 2013-12-17 6:26 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Andreas Dilger
Since commit 5ad07acad if $TMP cannot hold large test filesystems
for resize testing the resize_test creates temporary test files
in the local working directory. Since it overrides TMPFILE locally
the calling program does not delete the generated file correctly.
Delete the large $TMPFILE within resize_test if it passes, but leave
it for debugging if the test failed.
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
tests/scripts/resize_test | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/scripts/resize_test b/tests/scripts/resize_test
index 30532a5..6a8b0e9 100755
--- a/tests/scripts/resize_test
+++ b/tests/scripts/resize_test
@@ -149,6 +149,7 @@ then
return 1
fi
+rm $TMPFILE
return 0
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: delete temporary resize test files
2013-12-17 6:26 [PATCH] tests: delete temporary resize test files Andreas Dilger
@ 2013-12-23 21:02 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2013-12-23 21:02 UTC (permalink / raw)
To: Andreas Dilger; +Cc: linux-ext4
On Mon, Dec 16, 2013 at 11:26:39PM -0700, Andreas Dilger wrote:
> Since commit 5ad07acad if $TMP cannot hold large test filesystems
> for resize testing the resize_test creates temporary test files
> in the local working directory. Since it overrides TMPFILE locally
> the calling program does not delete the generated file correctly.
>
> Delete the large $TMPFILE within resize_test if it passes, but leave
> it for debugging if the test failed.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-23 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 6:26 [PATCH] tests: delete temporary resize test files Andreas Dilger
2013-12-23 21:02 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).