linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: Johan Erlandsson <johan.erlandsson@sonyericsson.com>,
	"Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH] e2fsck: read only parameter incorrectly compared
Date: Thu, 19 Dec 2013 16:31:43 -0500	[thread overview]
Message-ID: <1387488703-18595-1-git-send-email-tytso@mit.edu> (raw)

From: Johan Erlandsson <johan.erlandsson@sonyericsson.com>

Don't check for lost+found in read only mode.

[Note: this patch was originally made against 1.41.14 version of
e2fsprogs found as part of the AOSP (Android Open Source Program)
tree.  My Signed-off-by relies on the fact that the original patch
author would have had to have filed a contribution agreement with Open
Handset Alliance before this commit before this commit was allowed
into the AOSP tree. -- tytso]

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

Note: This patch was original authored on August 2, 2012.  It would have
been nice if had been sent directly to upstream earlier, but oh, well.
(This patch was sent to me via Google's Android team.)

I will apply it against the maint branch and it will be in the 1.42.9
release.

 e2fsck/pass3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/e2fsck/pass3.c b/e2fsck/pass3.c
index d87bd79..32c05b5 100644
--- a/e2fsck/pass3.c
+++ b/e2fsck/pass3.c
@@ -112,7 +112,7 @@ void e2fsck_pass3(e2fsck_t ctx)
 	/*
 	 * Force the creation of /lost+found if not present
 	 */
-	if ((ctx->flags & E2F_OPT_READONLY) == 0)
+	if ((ctx->options & E2F_OPT_READONLY) == 0)
 		e2fsck_get_lost_and_found(ctx, 1);
 
 	/*
-- 
1.8.5.rc3.362.gdf10213


                 reply	other threads:[~2013-12-19 21:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387488703-18595-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=johan.erlandsson@sonyericsson.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).