From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Czerner Subject: [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Date: Wed, 16 Apr 2014 20:32:58 +0200 Message-ID: <1397673182-5326-1-git-send-email-lczerner@redhat.com> Cc: linkinjeon@gmail.com, Lukas Czerner To: linux-ext4@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47817 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754666AbaDPSdi (ORCPT ); Wed, 16 Apr 2014 14:33:38 -0400 Sender: linux-ext4-owner@vger.kernel.org List-ID: Currently we're passing -1 as lend argumnet for filemap_write_and_wait_range() which is wrong since lend is signed type so it would cause some confusion and we might not write_and_wait for the entire range we're expecting to write. Fix it by using LLONG_MAX instead. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index ff823b7..821c1d4 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5378,7 +5378,7 @@ int ext4_collapse_range(struct inode *inode, loff_t offset, loff_t len) punch_stop = (offset + len) >> EXT4_BLOCK_SIZE_BITS(sb); /* Write out all dirty pages */ - ret = filemap_write_and_wait_range(inode->i_mapping, offset, -1); + ret = filemap_write_and_wait_range(inode->i_mapping, offset, LLONG_MAX); if (ret) return ret; -- 1.8.3.1