linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] debugfs: fix debugfs/quota.c compile warnings
@ 2014-05-22  6:38 Andreas Dilger
  2014-05-22 21:57 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Dilger @ 2014-05-22  6:38 UTC (permalink / raw)
  To: tytso; +Cc: linux-ext4, Andreas Dilger

Fix type mismatch and unused variable warnings.

Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
 debugfs/quota.c |   21 ++++++++++-----------
 1 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/debugfs/quota.c b/debugfs/quota.c
index 95d064b..5589c1a 100644
--- a/debugfs/quota.c
+++ b/debugfs/quota.c
@@ -93,18 +93,19 @@ static int parse_quota_type(const char *cmdname, const char *str)
 static int list_quota_callback(struct dquot *dq, void *cb_data)
 {
 	printf("%8u   %8lld %8lld %8lld    %8lld %8lld %8lld\n",
-	       dq->dq_id, dq->dq_dqb.dqb_curspace,
-	       dq->dq_dqb.dqb_bsoftlimit, dq->dq_dqb.dqb_bhardlimit,
-	       dq->dq_dqb.dqb_curinodes,
-	       dq->dq_dqb.dqb_isoftlimit, dq->dq_dqb.dqb_ihardlimit);
+	       dq->dq_id, (long long)dq->dq_dqb.dqb_curspace,
+	       (long long)dq->dq_dqb.dqb_bsoftlimit,
+	       (long long)dq->dq_dqb.dqb_bhardlimit,
+	       (long long)dq->dq_dqb.dqb_curinodes,
+	       (long long)dq->dq_dqb.dqb_isoftlimit,
+	       (long long)dq->dq_dqb.dqb_ihardlimit);
 	return 0;
 }
 
 void do_list_quota(int argc, char *argv[])
 {
 	errcode_t	retval;
-	int		i, type;
-	int		flags = 0;
+	int		type;
 	struct quota_handle *qh;
 
 	if (load_quota_ctx(argv[0]))
@@ -132,9 +133,7 @@ void do_list_quota(int argc, char *argv[])
 
 void do_get_quota(int argc, char *argv[])
 {
-	errcode_t	retval;
-	int		i, err, type;
-	int		flags = 0;
+	int		err, type;
 	struct quota_handle *qh;
 	struct dquot	*dq;
 	qid_t		id;
@@ -165,7 +164,7 @@ void do_get_quota(int argc, char *argv[])
 	if (dq) {
 		list_quota_callback(dq, NULL);
 		ext2fs_free_mem(&dq);
-	} else
+	} else {
 		com_err(argv[0], 0, "couldn't read quota record");

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] debugfs: fix debugfs/quota.c compile warnings
  2014-05-22  6:38 [PATCH] debugfs: fix debugfs/quota.c compile warnings Andreas Dilger
@ 2014-05-22 21:57 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2014-05-22 21:57 UTC (permalink / raw)
  To: Andreas Dilger; +Cc: linux-ext4

On Thu, May 22, 2014 at 12:38:07AM -0600, Andreas Dilger wrote:
> Fix type mismatch and unused variable warnings.
> 
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>

Thanks, applied.

				- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-22 21:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-22  6:38 [PATCH] debugfs: fix debugfs/quota.c compile warnings Andreas Dilger
2014-05-22 21:57 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).