From: Ross Burton <ross.burton@intel.com>
To: linux-ext4@vger.kernel.org
Cc: dvhart@linux.intel.com, liezhi.yang@windriver.com,
darrick.wong@oracle.com, tytso@mit.edu
Subject: [PATCH][V2] misc: copy extended attributes in populate_fs
Date: Mon, 30 Jun 2014 20:22:17 +0100 [thread overview]
Message-ID: <1404156137-31473-1-git-send-email-ross.burton@intel.com> (raw)
When creating a file system using a source directory, also copy any extended
attributes that have been set.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
misc/create_inode.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/misc/create_inode.c b/misc/create_inode.c
index c9c99b5..31f2d3c 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -103,6 +103,91 @@ static errcode_t set_inode_extra(ext2_filsys fs, ext2_ino_t cwd,
return retval;
}
+static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino, const char *filename)
+{
+ errcode_t retval, close_retval;
+ struct ext2_inode inode;
+ struct ext2_xattr_handle *handle;
+ ssize_t size, value_size;
+ char *list;
+ int i;
+
+ size = llistxattr(filename, NULL, 0);
+ if (size == -1) {
+ com_err(__func__, errno, "llistxattr failed on %s", filename);
+ return errno;
+ } else if (size == 0) {
+ return 0;
+ }
+
+ retval = ext2fs_xattrs_open(fs, ino, &handle);
+ if (retval) {
+ if (retval == EXT2_ET_MISSING_EA_FEATURE)
+ return 0;
+ com_err(__func__, retval, "while opening inode %u", ino);
+ return retval;
+ }
+
+ list = malloc(size);
+ if (!list) {
+ com_err(__func__, errno, "whilst allocating memory");
+ retval = errno;
+ goto out;
+ }
+
+ size = llistxattr(filename, list, size);
+ if (size == -1) {
+ com_err(__func__, errno, "llistxattr failed on %s", filename);
+ retval = errno;
+ goto out;
+ }
+
+ for (i = 0; i < size; i += strlen(&list[i]) + 1) {
+ const char *name = &list[i];
+ char *value;
+
+ value_size = getxattr(filename, name, NULL, 0);
+ if (value_size == -1) {
+ com_err(__func__, errno, "getxattr failed on %s", filename);
+ retval = errno;
+ break;
+ }
+
+ value = malloc(value_size);
+ if (!value) {
+ com_err(__func__, errno, "whilst allocating memory");
+ retval = errno;
+ break;
+ }
+
+ value_size = getxattr(filename, name, value, value_size);
+ if (value_size == -1) {
+ free(value);
+ com_err(__func__, errno, "getxattr failed on %s", filename);
+ retval = errno;
+ break;
+ }
+
+ retval = ext2fs_xattr_set(handle, name, value, value_size);
+ free (value);
+ if (retval) {
+ com_err(__func__, retval, "while writing xattr %u", ino);
+ break;
+ }
+
+ }
+ out:
+ free(list);
+
+ close_retval = ext2fs_xattrs_close(&handle);
+ if (close_retval) {
+ com_err(__func__, retval, "while closing inode %u", ino);
+ retval = retval ? close_retval;
+ }
+
+ return retval;
+}
+
/* Make a special files (block and character devices), fifo's, and sockets */
errcode_t do_mknod_internal(ext2_filsys fs, ext2_ino_t cwd, const char *name,
struct stat *st)
@@ -615,6 +700,13 @@ static errcode_t __populate_fs(ext2_filsys fs, ext2_ino_t parent_ino,
goto out;
}
+ retval = set_inode_xattr(fs, ino, name);
+ if (retval) {
+ com_err(__func__, retval,
+ _("while setting xattrs for \"%s\""), name);
+ goto out;
+ }
+
/* Save the hardlink ino */
if (save_inode) {
/*
--
1.7.10.4
next reply other threads:[~2014-06-30 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 19:22 Ross Burton [this message]
2014-07-09 16:30 ` [PATCH][V2] misc: copy extended attributes in populate_fs Burton, Ross
2014-07-09 18:51 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404156137-31473-1-git-send-email-ross.burton@intel.com \
--to=ross.burton@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).