linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Azat Khuzhin <a3at.mail@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, darrick.wong@oracle.com, adilger@dilger.ca,
	Azat Khuzhin <a3at.mail@gmail.com>
Subject: [PATCH 2/4 v3] tune2fs: remove_journal_device(): use the correct block to find jsb
Date: Mon, 28 Jul 2014 11:43:23 +0400	[thread overview]
Message-ID: <1406533405-6899-3-git-send-email-a3at.mail@gmail.com> (raw)
In-Reply-To: <1406533405-6899-1-git-send-email-a3at.mail@gmail.com>

Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
---
 misc/tune2fs.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index ff50f37..1df655a 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -188,6 +188,7 @@ static int remove_journal_device(ext2_filsys fs)
 	errcode_t	retval;
 	int		commit_remove_journal = 0;
 	io_manager	io_ptr;
+	int start;
 
 	if (f_flag)
 		commit_remove_journal = 1; /* force removal even if error */
@@ -224,8 +225,10 @@ static int remove_journal_device(ext2_filsys fs)
 		goto no_valid_journal;
 	}
 
+	start = ext2fs_journal_sb_start(fs->blocksize);
 	/* Get the journal superblock */
-	if ((retval = io_channel_read_blk64(jfs->io, 1, -SUPERBLOCK_SIZE, buf))) {
+	if ((retval = io_channel_read_blk64(jfs->io, start,
+	    -SUPERBLOCK_SIZE, buf))) {
 		com_err(program_name, retval, "%s",
 			_("while reading journal superblock"));
 		goto no_valid_journal;
@@ -256,7 +259,8 @@ static int remove_journal_device(ext2_filsys fs)
 	jsb->s_nr_users = htonl(nr_users);
 
 	/* Write back the journal superblock */
-	if ((retval = io_channel_write_blk64(jfs->io, 1, -SUPERBLOCK_SIZE, buf))) {
+	if ((retval = io_channel_write_blk64(jfs->io, start,
+	    -SUPERBLOCK_SIZE, buf))) {
 		com_err(program_name, retval,
 			"while writing journal superblock.");
 		goto no_valid_journal;
-- 
2.0.1


  parent reply	other threads:[~2014-07-28  7:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28  7:43 [PATCH 0/4 v3] e2fsprogs journal fixes (UUID and 1k block size issue) Azat Khuzhin
2014-07-28  7:43 ` [PATCH 1/4 v3] journal: use consts instead of 1024 and add helper for journal with 1k blocksize Azat Khuzhin
2014-07-28  7:43 ` Azat Khuzhin [this message]
2014-07-28  7:43 ` [PATCH 3/4 v3] tune2fs: update journal super block when changing UUID for fs Azat Khuzhin
2014-07-31 15:16   ` Eric Sandeen
2014-07-31 15:45     ` Azat Khuzhin
2014-08-01  6:40       ` Andreas Dilger
2014-07-31 15:53     ` [PATCH] tune2fs: fix uninitialized variable in remove_journal_device Theodore Ts'o
2014-08-01  6:38       ` Andreas Dilger
2014-08-02  1:32         ` Theodore Ts'o
2014-07-28  7:43 ` [PATCH 4/4 v3] tune2fs: update journal users while updating fs UUID (with external journal) Azat Khuzhin
2014-07-28 20:07 ` [PATCH 0/4 v3] e2fsprogs journal fixes (UUID and 1k block size issue) Andreas Dilger
2014-07-28 21:05   ` Theodore Ts'o
2014-07-29 11:36 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406533405-6899-3-git-send-email-a3at.mail@gmail.com \
    --to=a3at.mail@gmail.com \
    --cc=adilger@dilger.ca \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).