linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>,
	Eryu Guan <eguan@redhat.com>
Subject: [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes
Date: Sun,  7 Sep 2014 08:29:02 -0400	[thread overview]
Message-ID: <1410092942-22201-1-git-send-email-tytso@mit.edu> (raw)

Using "yes | mkfs.ext4 ..." results in the error message results in
the test failing, at least for some versions of e2fsprogs:

    +yes: standard output: Broken pipe
    +yes: write error

It better to use the -F option, which will eliminate the questions.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: Eryu Guan <eguan@redhat.com>
---
 tests/ext4/003 | 2 +-
 tests/ext4/306 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ext4/003 b/tests/ext4/003
index 572e685..a2e9d75 100755
--- a/tests/ext4/003
+++ b/tests/ext4/003
@@ -43,7 +43,7 @@ _require_ext4_bigalloc
 
 rm -f $seqres.full
 
-yes | mkfs.ext4 -O bigalloc -C 65536  -g 256 $SCRATCH_DEV 512m \
+mkfs.ext4 -F -O bigalloc -C 65536  -g 256 $SCRATCH_DEV 512m \
 	>> $seqres.full 2>&1
 _scratch_mount || _fail "couldn't mount fs"
 
diff --git a/tests/ext4/306 b/tests/ext4/306
index fd50b0e..fd5c3a2 100755
--- a/tests/ext4/306
+++ b/tests/ext4/306
@@ -48,7 +48,7 @@ _require_scratch
 rm -f $seqres.full
 
 # Make a small ext4 fs with extents disabled & mount it
-yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1
+mkfs.ext4 -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1
 _scratch_mount || _fail "couldn't mount fs"
 
 # Create a small non-extent-based file
-- 
2.1.0


             reply	other threads:[~2014-09-07 12:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-07 12:29 Theodore Ts'o [this message]
2014-09-07 15:49 ` [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Christoph Hellwig
2014-09-07 19:21   ` Theodore Ts'o
2014-09-08  2:06     ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Theodore Ts'o
2014-09-08  2:06       ` [PATCH 2/2] ext4: speed up _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc Theodore Ts'o
2014-09-08  9:50         ` Dave Chinner
2014-09-08 12:02           ` Theodore Ts'o
2014-09-08 12:15             ` [PATCH -v2] " Theodore Ts'o
2014-09-08 12:36               ` Dave Chinner
2014-09-08 12:39                 ` Theodore Ts'o
2014-09-08 12:50                   ` Dave Chinner
2014-09-08 12:35       ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Dave Chinner
2014-09-27  0:11         ` Dave Chinner
2014-09-27 22:12           ` Theodore Ts'o
2014-09-09 11:49 ` [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410092942-22201-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=wangxg.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).