From: Theodore Ts'o <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
david@fromorbit.com, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH -v2] ext4: speed up _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc
Date: Mon, 8 Sep 2014 08:15:41 -0400 [thread overview]
Message-ID: <1410178541-15192-1-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <20140908120213.GF1066@thunk.org>
We don't need to make a full-sized file system in order to test
whether "mkfs.ext4 -O bigalloc" works.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
common/rc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/rc b/common/rc
index 285bd7c..0baac86 100644
--- a/common/rc
+++ b/common/rc
@@ -1189,7 +1189,7 @@ _require_xfs_crc()
#
_require_ext4_mkfs_bigalloc()
{
- _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1 \
+ $MKFS_EXT4_PROG -F -O bigalloc -n $SCRATCH_DEV 200k >/dev/null 2>&1 \
|| _notrun "mkfs.ext4 doesn't have bigalloc feature"
}
@@ -1197,7 +1197,7 @@ _require_ext4_mkfs_bigalloc()
#
_require_ext4_bigalloc()
{
- _scratch_mkfs_ext4 -O bigalloc >/dev/null 2>&1
+ $MKFS_EXT4_PROG -F -O bigalloc $SCRATCH_DEV 200k >/dev/null 2>&1
_scratch_mount >/dev/null 2>&1 \
|| _notrun "Ext4 kernel doesn't support bigalloc feature"
umount $SCRATCH_MNT
--
2.1.0
next prev parent reply other threads:[~2014-09-08 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 12:29 [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Theodore Ts'o
2014-09-07 15:49 ` Christoph Hellwig
2014-09-07 19:21 ` Theodore Ts'o
2014-09-08 2:06 ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Theodore Ts'o
2014-09-08 2:06 ` [PATCH 2/2] ext4: speed up _require_ext4_bigalloc and _require_ext4_mkfs_bigalloc Theodore Ts'o
2014-09-08 9:50 ` Dave Chinner
2014-09-08 12:02 ` Theodore Ts'o
2014-09-08 12:15 ` Theodore Ts'o [this message]
2014-09-08 12:36 ` [PATCH -v2] " Dave Chinner
2014-09-08 12:39 ` Theodore Ts'o
2014-09-08 12:50 ` Dave Chinner
2014-09-08 12:35 ` [PATCH 1/2] ext4: define MKFS_EXT4_PROG and use it instead of "mkfs.ext4" / "mkfs -t ext4" Dave Chinner
2014-09-27 0:11 ` Dave Chinner
2014-09-27 22:12 ` Theodore Ts'o
2014-09-09 11:49 ` [PATCH] ext4: use mkfs.ext4 -F instead of piping in yes Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410178541-15192-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).