* [PATCH 1/2] ext4: Don't check quota format when there are no quota files
@ 2014-09-16 20:38 Jan Kara
2014-09-16 20:38 ` [PATCH 2/2] ext3: " Jan Kara
2014-09-18 5:13 ` [PATCH 1/2] ext4: " Theodore Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kara @ 2014-09-16 20:38 UTC (permalink / raw)
To: Ted Tso; +Cc: linux-ext4, Jan Kara, stable
The check whether quota format is set even though there are no
quota files with journalled quota is pointless and it actually
makes it impossible to turn off journalled quotas (as there's
no way to unset journalled quota format). Just remove the check.
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/super.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0b28b36e7915..3ff598f3d4af 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1712,13 +1712,6 @@ static int parse_options(char *options, struct super_block *sb,
"not specified");
return 0;
}
- } else {
- if (sbi->s_jquota_fmt) {
- ext4_msg(sb, KERN_ERR, "journaled quota format "
- "specified with no journaling "
- "enabled");
- return 0;
- }
}
#endif
if (test_opt(sb, DIOREAD_NOLOCK)) {
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ext3: Don't check quota format when there are no quota files
2014-09-16 20:38 [PATCH 1/2] ext4: Don't check quota format when there are no quota files Jan Kara
@ 2014-09-16 20:38 ` Jan Kara
2014-09-18 5:13 ` [PATCH 1/2] ext4: " Theodore Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2014-09-16 20:38 UTC (permalink / raw)
To: Ted Tso; +Cc: linux-ext4, Jan Kara, stable
The check whether quota format is set even though there are no
quota files with journalled quota is pointless and it actually
makes it impossible to turn off journalled quotas (as there's
no way to unset journalled quota format). Just remove the check.
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext3/super.c | 7 -------
1 file changed, 7 deletions(-)
I'm going to queue this patch unless someone objects.
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 622e88249024..2c42e739e3d1 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1354,13 +1354,6 @@ set_qf_format:
"not specified.");
return 0;
}
- } else {
- if (sbi->s_jquota_fmt) {
- ext3_msg(sb, KERN_ERR, "error: journaled quota format "
- "specified with no journaling "
- "enabled.");
- return 0;
- }
}
#endif
return 1;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ext4: Don't check quota format when there are no quota files
2014-09-16 20:38 [PATCH 1/2] ext4: Don't check quota format when there are no quota files Jan Kara
2014-09-16 20:38 ` [PATCH 2/2] ext3: " Jan Kara
@ 2014-09-18 5:13 ` Theodore Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2014-09-18 5:13 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, stable
On Tue, Sep 16, 2014 at 10:38:24PM +0200, Jan Kara wrote:
> The check whether quota format is set even though there are no
> quota files with journalled quota is pointless and it actually
> makes it impossible to turn off journalled quotas (as there's
> no way to unset journalled quota format). Just remove the check.
>
> CC: stable@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ext4: Don't check quota format when there are no quota files
2014-10-10 14:23 [PATCH 0/2 v2] Fix data corruption when blocksize < pagesize for mmapped data Jan Kara
@ 2014-10-10 14:23 ` Jan Kara
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2014-10-10 14:23 UTC (permalink / raw)
To: linux-fsdevel
Cc: Dave Kleikamp, jfs-discussion, tytso, Jeff Mahoney, Mark Fasheh,
Dave Chinner, reiserfs-devel, stable, xfs, cluster-devel,
Jan Kara, linux-ext4, Steven Whitehouse, ocfs2-devel, viro
The check whether quota format is set even though there are no
quota files with journalled quota is pointless and it actually
makes it impossible to turn off journalled quotas (as there's
no way to unset journalled quota format). Just remove the check.
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/super.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0b28b36e7915..3ff598f3d4af 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1712,13 +1712,6 @@ static int parse_options(char *options, struct super_block *sb,
"not specified");
return 0;
}
- } else {
- if (sbi->s_jquota_fmt) {
- ext4_msg(sb, KERN_ERR, "journaled quota format "
- "specified with no journaling "
- "enabled");
- return 0;
- }
}
#endif
if (test_opt(sb, DIOREAD_NOLOCK)) {
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-10 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 20:38 [PATCH 1/2] ext4: Don't check quota format when there are no quota files Jan Kara
2014-09-16 20:38 ` [PATCH 2/2] ext3: " Jan Kara
2014-09-18 5:13 ` [PATCH 1/2] ext4: " Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2014-10-10 14:23 [PATCH 0/2 v2] Fix data corruption when blocksize < pagesize for mmapped data Jan Kara
2014-10-10 14:23 ` [PATCH 1/2] ext4: Don't check quota format when there are no quota files Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).