* [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock
@ 2015-03-24 13:11 Maurizio Lombardi
2015-03-24 14:53 ` Lukáš Czerner
2015-04-03 4:04 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Maurizio Lombardi @ 2015-03-24 13:11 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso
This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
fs/ext4/balloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 83a6f49..2072c70 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -641,8 +641,6 @@ ext4_fsblk_t ext4_new_meta_blocks(handle_t *handle, struct inode *inode,
* fail EDQUOT for metdata, but we do account for it.
*/
if (!(*errp) && (flags & EXT4_MB_DELALLOC_RESERVED)) {
- spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
- spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
dquot_alloc_block_nofail(inode,
EXT4_C2B(EXT4_SB(inode->i_sb), ar.len));
}
--
Maurizio Lombardi
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock
2015-03-24 13:11 [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock Maurizio Lombardi
@ 2015-03-24 14:53 ` Lukáš Czerner
2015-04-03 4:04 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Lukáš Czerner @ 2015-03-24 14:53 UTC (permalink / raw)
To: Maurizio Lombardi; +Cc: linux-ext4, tytso
On Tue, 24 Mar 2015, Maurizio Lombardi wrote:
> Date: Tue, 24 Mar 2015 14:11:44 +0100
> From: Maurizio Lombardi <mlombard@redhat.com>
> To: linux-ext4@vger.kernel.org
> Cc: tytso@mit.edu
> Subject: [PATCH] ext4: remove unnecessary lock/unlock of
> i_block_reservation_lock
>
> This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1
Ah yes, seems we're only now finding missing leftovers from that
commit :)
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks!
-Lukas
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> fs/ext4/balloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 83a6f49..2072c70 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -641,8 +641,6 @@ ext4_fsblk_t ext4_new_meta_blocks(handle_t *handle, struct inode *inode,
> * fail EDQUOT for metdata, but we do account for it.
> */
> if (!(*errp) && (flags & EXT4_MB_DELALLOC_RESERVED)) {
> - spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
> - spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> dquot_alloc_block_nofail(inode,
> EXT4_C2B(EXT4_SB(inode->i_sb), ar.len));
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock
2015-03-24 13:11 [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock Maurizio Lombardi
2015-03-24 14:53 ` Lukáš Czerner
@ 2015-04-03 4:04 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2015-04-03 4:04 UTC (permalink / raw)
To: Maurizio Lombardi; +Cc: linux-ext4
On Tue, Mar 24, 2015 at 02:11:44PM +0100, Maurizio Lombardi wrote:
> This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-03 4:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24 13:11 [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock Maurizio Lombardi
2015-03-24 14:53 ` Lukáš Czerner
2015-04-03 4:04 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).